Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove Infrastructure Dependency on Web #54
Build is failing, probably because it's running on linux not Windows and the build script is using the windows copy command?
@ardalis yeah looks like it. Digging into the build log I found:
And after Infrastructure builds we indeed call that post-build event:
It looks like the post-build step to manually copy the Infrastructure DLL to the output directory needs to be updated to a universal copy command of some kind.
Xeinaemm left a comment •
I wonder that its appropriate way of thinking about removing infrastructure reference.
We can have two different approaches to building an app with this architecture.
First, self-hosted REST API + self-hosted SPA, that definitely remove reference to the infrastructure and keep all necessary references in place without hacks.
Second, both in bulk as now, but what about the situation when you will add some logic to infrastructure that belongs to configuration or helpers(with 3rd part references) and you need to use them in Web API?
You can create an adapter to your own facade that hides implementation under core's service interfaces, but this overhead to helpers is appropriate?
As we know, developers are lazy and creating an abstraction over common mechanisms like extensions will be too much for some people.
I don't really see that web should have any additional logic despite display a result or create endpoints because we will just copy and paste this same 3rd part references and it can create friction because it's used in two places(infrastructure and web).
On the other hand, it completely hides all logic under services or repositories, you cannot force to break that and I agree that is the best way of thinking but with some boilerplate code.