fix issue with connected lines

ardata-fr · Apr 28, 2021 · b38c6e8 · b38c6e8
1 parent 07d651f
commit b38c6e8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: mschart
 Type: Package
 Title: Chart Generation for 'Microsoft Word' and 'Microsoft PowerPoint' Documents
-Version: 0.3.1.003
+Version: 0.3.1.004
 Authors@R: c(
     person("David", "Gohel", role = c("aut", "cre"), 
       email = "david.gohel@ardata.fr"),

diff --git a/NEWS.md b/NEWS.md
@@ -7,6 +7,7 @@
 ## Issues
 
 * fix issue with scattercharts and ordering in the Excel dataset
+* fix issue with scattercharts when points should be joined by a line
 
 # mschart 0.3.0
 

diff --git a/R/to_pml.R b/R/to_pml.R
@@ -189,7 +189,7 @@ to_pml.ms_scatterchart <- function(x, id_x, id_y, sheetname = "sheet1", add_ns =
                       sheetname = sheetname )
   str_series_ <- sapply( series, function(serie, has_line, has_marker ){
 
-    if( !has_line ){
+    if( !has_line || serie$line_style %in% "none" || serie$line_width < 1){
       line_str <- "<c:spPr><a:ln><a:noFill/></a:ln></c:spPr>"
     } else {
       line_properties <- fp_border(color = serie$stroke, style = serie$line_style, width = serie$line_width)