Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loadSchema): add optional chaining #1696

Merged
merged 1 commit into from Jul 1, 2020
Merged

Conversation

@jameslahm
Copy link
Contributor

jameslahm commented Jun 26, 2020

fix(loadSchema): add optional chaining

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
fix(loadSchema): add optional chaining
@jameslahm
Copy link
Contributor Author

jameslahm commented Jun 26, 2020

Hi, it seems not passing options argument will cause no includeSources property on undefined error when using loadSchema or loadSchemaSync, for example, when loading from string directly, and add optional chain may be useful

@ardatan ardatan changed the title Update schema.ts fix(loadSchema): add optional chaining Jul 1, 2020
@ardatan ardatan added the bugfix label Jul 1, 2020
@ardatan ardatan merged commit 6e731b8 into ardatan:master Jul 1, 2020
20 checks passed
20 checks passed
automerge
Details
automerge
Details
automerge
Details
automerge
Details
automerge
Details
automerge
Details
automerge
Details
automerge
Details
Publish Canary
Details
Lint
Details
Build on GraphQL v14
Details
Build on GraphQL v15
Details
Test on ubuntu-latest, Node 10 and GraphQL v14
Details
Test on ubuntu-latest, Node 10 and GraphQL v15
Details
Test on ubuntu-latest, Node 14 and GraphQL v14
Details
Test on ubuntu-latest, Node 14 and GraphQL v15
Details
Test on windows-latest, Node 10 and GraphQL v14
Details
Test on windows-latest, Node 10 and GraphQL v15
Details
Test on windows-latest, Node 14 and GraphQL v14
Details
Test on windows-latest, Node 14 and GraphQL v15
Details
@ardatan
Copy link
Owner

ardatan commented Jul 1, 2020

Thank you @jameslahm !

@theguild-bot
Copy link
Contributor

theguild-bot commented Jul 1, 2020

The latest changes of this PR are available as alpha in npm: 6.0.12-alpha-6e731b8.0

Quickly update your package.json by running:

npx match-version @graphql-tools 6.0.12-alpha-6e731b8.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.