Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(executor): handle thrown values that are not error instances correctly #6038

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Apr 8, 2024

Fixes #6039

Copy link

changeset-bot bot commented Apr 8, 2024

🦋 Changeset detected

Latest commit: 8c6f0fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-tools/executor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 8, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/executor 1.2.6-alpha-20240408110006-8c6f0fea3b2f1f9b128b7f1a818146b437244455 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Apr 8, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 350       ✗ 0  
     data_received..................: 41 MB   4.1 MB/s
     data_sent......................: 150 kB  15 kB/s
     http_req_blocked...............: avg=3.88µs   min=1.77µs  med=2.46µs   max=216.4µs  p(90)=3.47µs  p(95)=3.72µs  
     http_req_connecting............: avg=756ns    min=0s      med=0s       max=132.46µs p(90)=0s      p(95)=0s      
     http_req_duration..............: avg=52.96ms  min=45.84ms med=49.09ms  max=134.56ms p(90)=57.83ms p(95)=86.79ms 
       { expected_response:true }...: avg=52.96ms  min=45.84ms med=49.09ms  max=134.56ms p(90)=57.83ms p(95)=86.79ms 
     http_req_failed................: 0.00%   ✓ 0         ✗ 175
     http_req_receiving.............: avg=133.93µs min=107.3µs med=128.35µs max=415.04µs p(90)=145.3µs p(95)=156.67µs
     http_req_sending...............: avg=24.05µs  min=16.56µs med=23.77µs  max=62.51µs  p(90)=28.18µs p(95)=33.16µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s       p(90)=0s      p(95)=0s      
     http_req_waiting...............: avg=52.8ms   min=45.68ms med=48.94ms  max=134.15ms p(90)=57.67ms p(95)=86.63ms 
     http_reqs......................: 175     17.481876/s
     iteration_duration.............: avg=57.18ms  min=49.36ms med=53.27ms  max=138.36ms p(90)=63.08ms p(95)=90.58ms 
     iterations.....................: 175     17.481876/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

Copy link
Contributor

github-actions bot commented Apr 8, 2024

💻 Website Preview

The latest changes are available as preview in: https://1a945bd4.graphql-tools.pages.dev

@ardatan ardatan merged commit 02dd9ac into master Apr 8, 2024
30 checks passed
@ardatan ardatan deleted the error-handling-fetch branch April 8, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle thrown values correctly even if they are not instances of Error.
2 participants