Skip to content
This repository was archived by the owner on Apr 17, 2023. It is now read-only.

Conversation

@glowmouse
Copy link
Contributor

@glowmouse glowmouse commented Dec 1, 2018

When the Linux system path includes $(ARDUINO_SDK_PATH), CMAKE searches

$(ARDUINO_SDK_PATH)/libraries

for libraries instead of

$(ARDUINO_SDK_PATH)/hardware/arduino/avr/libraries

Adding NO_SYSTEM_ENVIRONMENT_PATH tells cmake not to consider the Linux Path when looking for files.

Fixes #58

Copy link
Member

@MrPointer MrPointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glowmouse Hi and welcome to the project!
It's a great fix here, and it's strange nobody has encountered it yet, not even the CI setup - As it does use the system PATH variable... Just take a look at my small change request and we're good to go.
Besides, I hope it won't break anything 😆

glowmouse added a commit to glowmouse/Arduino-CMake-NG that referenced this pull request Dec 8, 2018
Add ARDUINO_SDK_PATH to .travis.yml
glowmouse added a commit to glowmouse/Arduino-CMake-NG that referenced this pull request Dec 8, 2018
@glowmouse glowmouse force-pushed the bug/path-lib-fix branch 2 times, most recently from 7b7a77b to cd3abe2 Compare December 9, 2018 00:16
Copy link
Member

@MrPointer MrPointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the subtle implementation details we're currently discussing, I propose that this change will be reflected in all find_file occurrences regarding platform elements (It's part of the same file), since it may be duplicated in other elements as well, and it's a shame we won't fix everything at once.

@glowmouse I don't want to merge the fix until you resolve the written above as well, thanks.

may be used instead of the platform's directory

Fix for arduino-cmake#58
Copy link
Member

@MrPointer MrPointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks!

@MrPointer MrPointer merged commit c2e4cd1 into arduino-cmake:master Dec 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants