-
Notifications
You must be signed in to change notification settings - Fork 39
Do not look at the system PATH variable when looking for libraries. #59
Conversation
MrPointer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glowmouse Hi and welcome to the project!
It's a great fix here, and it's strange nobody has encountered it yet, not even the CI setup - As it does use the system PATH variable... Just take a look at my small change request and we're good to go.
Besides, I hope it won't break anything 😆
Add ARDUINO_SDK_PATH to .travis.yml
7b7a77b to
cd3abe2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the subtle implementation details we're currently discussing, I propose that this change will be reflected in all find_file occurrences regarding platform elements (It's part of the same file), since it may be duplicated in other elements as well, and it's a shame we won't fix everything at once.
@glowmouse I don't want to merge the fix until you resolve the written above as well, thanks.
may be used instead of the platform's directory Fix for arduino-cmake#58
e55e990 to
6e9b7f3
Compare
may be used instead of the platform's directory Fix for arduino-cmake#58
…no-CMake-NG into bug/path-lib-fix
MrPointer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, thanks!
When the Linux system path includes $(ARDUINO_SDK_PATH), CMAKE searches
$(ARDUINO_SDK_PATH)/libraries
for libraries instead of
$(ARDUINO_SDK_PATH)/hardware/arduino/avr/libraries
Adding NO_SYSTEM_ENVIRONMENT_PATH tells cmake not to consider the Linux Path when looking for files.
Fixes #58