src/BearSSLClient.cpp: fix _ecSign #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client can specify its own _ecSign function since commit 996778e as well as its own certificate since commit 874c6b0 The goal was to allow the user to use ArduinoBearSSL without the ECCX08 (for example with an (e)SIM applet compliant to the new GSMA IoT SAFE standard). However, these two functions don't work because br_ssl_client_set_single_ec is not called if _ecKey.xlen is set to 0 so fix this latest issue Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
|
Hi @ffontaine, thank you for your contribution! The PR is ok for me, but seeing @aentinger's comment in the PR #36 I would like to be sure this change cannot create any conflict in |
|
Hi @ffontaine, thank you for your contribution, I have merged the commit :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client can specify its own
_ecSignfunction since commit 996778e as well as its own certificate since commit 874c6b0.The goal was to allow the user to use ArduinoBearSSL without the ECCX08 (for example with an (e)SIM applet compliant to the new GSMA IoT SAFE standard).
However, these two functions don't work because
br_ssl_client_set_single_ecis not called if_ecKey.xlenis set to 0 so fix this latest issueSigned-off-by: Fabrice Fontaine fabrice.fontaine@orange.com