From fe6d4e2a6653578ab31d69b014ba21debdb7f360 Mon Sep 17 00:00:00 2001 From: Martino Facchin Date: Wed, 3 Nov 2021 15:24:40 +0100 Subject: [PATCH 1/3] Fix setGains() argument in example --- examples/MKR/Test/Test.ino | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/MKR/Test/Test.ino b/examples/MKR/Test/Test.ino index 71e107d..a7e0af8 100644 --- a/examples/MKR/Test/Test.ino +++ b/examples/MKR/Test/Test.ino @@ -46,7 +46,7 @@ void setup() { // This way, you can program the motor to reach a certain position or velocity without any further intervention. // The PID can be carefully tuned if a particular profile is needed. pid1.setControlMode(CL_POSITION); - pid1.setGains(25, 0, 3); + pid1.setGains(25.0f, 0.0f, 3.0f); pid1.setMaxAcceleration(4000); pid1.setSetpoint(TARGET_POSITION, 5000); } From f89b4162188dfb830ccf97da94ec9f6495b67700 Mon Sep 17 00:00:00 2001 From: Martino Facchin Date: Wed, 3 Nov 2021 15:24:53 +0100 Subject: [PATCH 2/3] Fix compilation for Portenta H7 --- src/Common.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Common.h b/src/Common.h index cdd374c..f31e330 100644 --- a/src/Common.h +++ b/src/Common.h @@ -14,6 +14,10 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +#ifdef ARDUINO_PORTENTA_H7_M7 +#define RESET _RESET +#endif + enum Commands { GET_VERSION = 0x01, RESET, From 480267020ba1e33f86a267601605319e0d9234ef Mon Sep 17 00:00:00 2001 From: Alexander Entinger Date: Fri, 30 Dec 2022 08:27:44 +0100 Subject: [PATCH 3/3] Fix CI build error also for H7/M4 core. --- src/Common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Common.h b/src/Common.h index f31e330..c59c821 100644 --- a/src/Common.h +++ b/src/Common.h @@ -14,7 +14,7 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#ifdef ARDUINO_PORTENTA_H7_M7 +#if defined(ARDUINO_PORTENTA_H7_M7) || defined(ARDUINO_PORTENTA_H7_M4) #define RESET _RESET #endif