-
Notifications
You must be signed in to change notification settings - Fork 18
Return LSM6DSOX temperature as float #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Memory usage change @ 3865633
Click for full report table
Click for full report CSV |
aentinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi ☕ 👋 You are not obeying the API contract with this change, i..e people who have passed an int to readTemperature will be in for a surprise. Please add another function, i.e. readTemperatureFloat to retrieve the float value (and may it only be a cast to the result of the other function).
|
I added the requested changes. I have to admit though, that I was definitely more surprised to learn it was reading the temperature as Is there a reason for it to be integer? |
|
I agree the API could have returned a |
aentinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Update temperature API to return temperature with greater precision as
float.This addresses this comment in #7.