Fix RGB LEDs colour order #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I understand this should be fixed by the new DotStar RGB library, @marqdevx ? If so, please close this PR. |
aentinger
force-pushed
the
ubidefeo-LED_order_fix
branch
2 times, most recently
from
cc5f496 to
9e63fe2
Compare
The current colour arrangement used for DotStar has Green and Red swapped. At least on my unit this is what I experience. This PR fixes the order to `DOTSTAR_BGR`, but it might be useful to check if different batches of APA102c ordered for production might have different colour order
aentinger
force-pushed
the
ubidefeo-LED_order_fix
branch
from
9e63fe2 to
9569445
Compare
|
@aentinger |
|
Well then please clean the stuff up and move forward, my question on 16/9/2021 directed specifically to you went unanswered ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current colour arrangement used for DotStar has Green and Red swapped.
At least on my unit this is what I experience.
This PR fixes the order to
DOTSTAR_BGR, but it might be useful to check if different batches of APA102c ordered for production might have different colour order