Skip to content

3 add a class for tcp socket clientserver #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 19, 2025
Merged

3 add a class for tcp socket clientserver #11

merged 8 commits into from
Sep 19, 2025

Conversation

@eigen-value
Copy link
Collaborator

@eigen-value eigen-value commented Sep 16, 2025

This PR implements TCP client (with SSL connection option) and TCP server classes + test examples

solves #3

@eigen-value
feat: tcp_server.h stub
b0800a9
@eigen-value
Merge branch 'main' into 3-add-a-class-for-tcp-socket-clientserver
8a75a47 
# Conflicts:
#	src/tcp_client.h
@eigen-value
mod: various TBT
7a455d2
@eigen-value
fix: main .h not including tcp classes
88057f3 
fix: client _read not passing connection_id
impr: server tcp/closeListener method
examples: client and clientSSL
@eigen-value
feat: BridgeTCPClient constructor for established connections
75b73ce 
feat: tcp_client getId method

feat: server-side client connection/disconnection

examples: server.ino with python test script
@eigen-value
mod: unused import in tcp_server
216937e
@eigen-value eigen-value requested review from cmaglie and gbr1 September 16, 2025 09:51
@eigen-value eigen-value linked an issue Sep 16, 2025 that may be closed by this pull request
Add a class for TCP socket Client/Server #3
Closed
gbr1
gbr1 requested changes Sep 16, 2025
View reviewed changes
Copy link
Collaborator

@gbr1 gbr1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please:

@per1234 per1234 added the enhancement New feature or request label Sep 16, 2025
@eigen-value
Copy link
Collaborator Author

eigen-value commented Sep 17, 2025

After a successful run of the tcp_server example if I do arduino-reset I get the following error:

2025/09/17 13:28:57 DEBUG Received response method=tcp/listen result=<nil> error="[2 Failed to start listening on address: listen tcp 127.0.0.1:5678: bind: address already in use]"

The router has a stale listener on reset.
Is there a way to handle tcp\listen multiple attempts on the same host+port? @cmaglie

@eigen-value
Copy link
Collaborator Author

eigen-value commented Sep 17, 2025

Please:

  • convert Serial to Monitor;
  • in SSL client example, don't use Ubi's website, use arduino tips instead
  • @cmaglie there is a conflict on tcp_server generated by this: bcmi-labs/orchestrator#658

@gbr1 Updated and ready

@gbr1 gbr1 self-requested a review September 19, 2025 13:57
gbr1
gbr1 approved these changes Sep 19, 2025
View reviewed changes
Copy link
Collaborator

@gbr1 gbr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested all examples

@gbr1 gbr1 merged commit 9226bd1 into main Sep 19, 2025
@gbr1 gbr1 deleted the 3-add-a-class-for-tcp-socket-clientserver branch September 19, 2025 13:58
@eigen-value eigen-value restored the 3-add-a-class-for-tcp-socket-clientserver branch September 30, 2025 08:30
@eigen-value eigen-value deleted the 3-add-a-class-for-tcp-socket-clientserver branch November 10, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gbr1 gbr1 gbr1 approved these changes

@cmaglie cmaglie Awaiting requested review from cmaglie

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a class for TCP socket Client/Server

4 participants

@eigen-value @gbr1 @per1234