Fixed normal SPI operations whilst using SigFox #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was actually just a typo in the header file which initialized the SigFox port to SPI by default; which means reassigning it to SIGFOX_SPI leads to the original SPI being deallocated. Not good :).
facchinm
added a commit
to facchinm/SigFox
that referenced
this pull request
Sep 4, 2017
|
Hi @jacobstim , the fix looks good to me, but it has a side effect (if you want to run the library on a different board with the same module it's SIGFOX_SPI is likely undeclared. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was actually which I assume to be a typo in the header file which initialized the SigFox port to SPI by default; which means reassigning it to SIGFOX_SPI leads to the original SPI being deallocated, breaking the original SPI operations.