Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions to Adafruit_WINC1500 to allow sketch request for DNS IP #87

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@R3Electronics
Copy link

commented Aug 13, 2016

Updated Adafruit_WINC1500.h and Adafruit_WINC1500.cpp to add option to read assigned DNS server IP address from user sketch. Simple code additions to add public member and function to return DNS IP Address for user sketch.

Readme includes addtion to example printWifiStatus to show usage.

Richard. Hewitt (RH3).

@sandeepmistry

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2016

Hi @R3Electronics,

Thank you for submitting this pull request. However, this Github repo does not host the Adafruit_WINC1500.h and Adafruit_WINC1500.cpp files which you edited.

We'd be happy to review any equivalent changes that are made to WiFi101.h and WiFi.cpp. Please remote the ReadMe file as well.

Thanks.

@sandeepmistry

This comment has been minimized.

Copy link
Contributor

commented Sep 7, 2016

I'm going to close this due to lack of activity. When the changes discussed in #87 (comment) are made we can re-open and re-discuss.

@R3Electronics

This comment has been minimized.

Copy link
Author

commented Sep 8, 2016

Hi Sandeep,

I checked with Rick over at Adafruit and I think there is some confusion. Rick mentioned to create a pull request for this change in the WiFi101, which I did. He later mentioned this is where Adafruit fork their build from so he may have been wrong initially.

Should I have made the proposed changes to the WINC1500 library rather than the Adafruit_WINC1500 version?

Regards,

Richard.

Date: Wed, 7 Sep 2016 07:21:16 -0700
From: notifications@github.com
To: WiFi101@noreply.github.com
CC: richard.hewitt@hotmail.com; mention@noreply.github.com
Subject: Re: [arduino-libraries/WiFi101] Additions to Adafruit_WINC1500 to allow sketch request for DNS IP (#87)

I'm going to close this due to lack of activity. When the changes discussed in #87 (comment) are made we can re-open and re-discuss.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@sandeepmistry

This comment has been minimized.

Copy link
Contributor

commented Sep 8, 2016

Should I have made the proposed changes to the WINC1500 library rather than the Adafruit_WINC1500 version?

Hi @R3Electronics, it's up to you really. If you'd like to contribute to this version please do. The next release will include a WiFi.setPins(...) API to make it compatible with any WINC1500 based board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.