Snapshot icons #34
Merged
Snapshot icons #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Motivation and Context
With #28 we changed the semantic of
GSJSensorSpec.rememberedAppearance. Now we're reverting back this change, handling it in a different way.Description
After #28 we created an
IconPathof type.proto, setting the sensor's identifier as thepathString. However this modification broke the original specification ofGSJIconPath_PathTypethat says thatpathStringshould be empty (and also some unit tests failed for this). In order to fix this we're using a different method to get the sensor icon that is not built in.