Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve low free memory reporting #1775

Merged
merged 1 commit into from May 3, 2014
Merged

Improve low free memory reporting #1775

merged 1 commit into from May 3, 2014

Conversation

@ribbons
Copy link

@ribbons ribbons commented Jan 1, 2014

A couple of small enhancements to the memory usage report at the end of a successful compile:

  • Send the low available memory warning to err rather than out so that it appears as a more visible warning.
  • Remember the size of the text and data from the last compile and show how much of a change there was (if any).
Write the low available memory message to err rather than out so that it
appears more like a warning and is more noticeable.
@ribbons
Copy link
Author

@ribbons ribbons commented Feb 2, 2014

@cmaglie Would it be possible for you to take a quick look at this when time permits?

@ribbons
Copy link
Author

@ribbons ribbons commented Mar 23, 2014

Is there a problem with what I'm proposing in this PR or the way I've implemented it, or is it just a case of waiting until it reaches the top of the pile?

@cmaglie
Copy link
Member

@cmaglie cmaglie commented Apr 1, 2014

Hi @ribbons!
I'm really sorry for the delay.

These two lines of text are the most "disputed" in the history of Arduino, currently they are the result of a ton of discussions and mediation between two opposite designs: a lot of information but terse and potentially confusing (for the beginner) vs. concise information but clearly explained.
Let me check this patch with the developers list to see if there are concerns (or maybe you want to do it?).

@ribbons ribbons changed the title Memory usage reporting enhancements Low memory usage reporting enhancement May 2, 2014
@ribbons ribbons changed the title Low memory usage reporting enhancement Improve low memory usage reporting May 2, 2014
@ribbons ribbons changed the title Improve low memory usage reporting Improve low free memory reporting May 2, 2014
@ribbons
Copy link
Author

@ribbons ribbons commented May 2, 2014

Hi @cmaglie, as the general agreement on the developers mailing list was that the memory usage delta display wasn't really of use, I've dropped that commit out of this PR.

This just leaves the commit which fixes a whitespace error and sends the low available memory warning to err instead of out (causing it to appear in orange instead of white text in the IDE). Would that be something that you would consider merging?

cmaglie added a commit that referenced this issue May 3, 2014
Improve low free memory reporting
@cmaglie cmaglie merged commit d025638 into arduino:ide-1.5.x May 3, 2014
@cmaglie
Copy link
Member

@cmaglie cmaglie commented May 3, 2014

Yup, thanks.

@ribbons ribbons deleted the memory-usage branch May 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants