New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the serial monitor to stay opened during upload, disabling it #1891

Closed
wants to merge 1 commit into
base: master
from

Conversation

7 participants
@avishorp
Contributor

avishorp commented Feb 24, 2014

Currently, the serial monitor window closes when starting program uploading. I find this behavior very annoying since the monitor window has to be opened over and over again after each upload. The attached patch fixes this issue. When upload starts, the window gets disabled. When the upload process ends the window gets re-enabled and become operational immediately (if it is visible). The user can also now open the serial monitor window while uploading is in progress.

@tchilton

This comment has been minimized.

Show comment
Hide comment
@tchilton

tchilton May 3, 2014

Or alternately, the IDE should re-open the serial monitor automatically when the build has completed. If the developer is monitoring the serial, they probably care whats coming out of it, so manually clicking to re-open is not great usability and just slows things down.

tchilton commented May 3, 2014

Or alternately, the IDE should re-open the serial monitor automatically when the build has completed. If the developer is monitoring the serial, they probably care whats coming out of it, so manually clicking to re-open is not great usability and just slows things down.

@avishorp

This comment has been minimized.

Show comment
Hide comment
@avishorp

avishorp May 21, 2014

Contributor

I think that enabling/disabling is cleaner in the UI respect.

Contributor

avishorp commented May 21, 2014

I think that enabling/disabling is cleaner in the UI respect.

@matthijskooijman

This comment has been minimized.

Show comment
Hide comment
@matthijskooijman

matthijskooijman Jun 30, 2014

Collaborator

I agree that this is the cleanest way to implement this feature.

I had a look at this code, it looks good to me. I haven't actually tested it, though.

@cmaglie, any plans to merge this?
@avishorp, did you see if the same patch applies to the 1.5.x branch? If @cmaglie agrees that this is the best approach, perhaps you could prepare a pullreq for 1.5.x as well?

Collaborator

matthijskooijman commented Jun 30, 2014

I agree that this is the cleanest way to implement this feature.

I had a look at this code, it looks good to me. I haven't actually tested it, though.

@cmaglie, any plans to merge this?
@avishorp, did you see if the same patch applies to the 1.5.x branch? If @cmaglie agrees that this is the best approach, perhaps you could prepare a pullreq for 1.5.x as well?

@avishorp

This comment has been minimized.

Show comment
Hide comment
@avishorp

avishorp Jun 30, 2014

Contributor

No problem, I'll prepare a pull request when it is approved.

Contributor

avishorp commented Jun 30, 2014

No problem, I'll prepare a pull request when it is approved.

@andreujuanc

This comment has been minimized.

Show comment
Hide comment
@andreujuanc

andreujuanc Jun 30, 2014

Oh! Great!! Sorry i didnt see this thread before posting. It was LATE (3am) or so.

Let me know if I can help with implementation. I'll download code at night.

Regards,

andreujuanc commented Jun 30, 2014

Oh! Great!! Sorry i didnt see this thread before posting. It was LATE (3am) or so.

Let me know if I can help with implementation. I'll download code at night.

Regards,

@matthijskooijman

This comment has been minimized.

Show comment
Hide comment
@matthijskooijman

matthijskooijman Jun 30, 2014

Collaborator

@andreujuanc, Testing the code in this pullrequest and providing feedback would help. Thanks!

Collaborator

matthijskooijman commented Jun 30, 2014

@andreujuanc, Testing the code in this pullrequest and providing feedback would help. Thanks!

@andreujuanc

This comment has been minimized.

Show comment
Hide comment
@andreujuanc

andreujuanc Jul 2, 2014

Guys, I cant clone it. Downloading data takes lots of time and then suddenly fails (After almost an hour downloading).

Downloading speed average is about 200KB/s. Sometimes goes to 600 and then stays below 100 for someminutes then goes again to more or less 200KB/s.

Tried downloading the ZIP file and it takes even longer, canceled cos cant wait if it goes at 20KB/s.

Any ideas?

Thanks

andreujuanc commented Jul 2, 2014

Guys, I cant clone it. Downloading data takes lots of time and then suddenly fails (After almost an hour downloading).

Downloading speed average is about 200KB/s. Sometimes goes to 600 and then stays below 100 for someminutes then goes again to more or less 200KB/s.

Tried downloading the ZIP file and it takes even longer, canceled cos cant wait if it goes at 20KB/s.

Any ideas?

Thanks

@matthijskooijman

This comment has been minimized.

Show comment
Hide comment
@matthijskooijman

matthijskooijman Jul 3, 2014

Collaborator

Hmm, sounds like you have a bad connection? Perhaps contacting github support would help? Not sure how to get at the source, if not through github...

Collaborator

matthijskooijman commented Jul 3, 2014

Hmm, sounds like you have a bad connection? Perhaps contacting github support would help? Not sure how to get at the source, if not through github...

@andreujuanc

This comment has been minimized.

Show comment
Hide comment
@andreujuanc

andreujuanc Jul 6, 2014

Got it with SSH :S and its not my internet/PC fault. Whatever.

Now i got the project I had no idea that i have to do ALL OF THIS: https://code.google.com/p/arduino/wiki/BuildingArduino just to compile arduino. Any other faster way? Only to build and debug the IDE.

Can I somehow create a netbeans project and just debbug the IDE?
PS: Im not an active java programmer.

andreujuanc commented Jul 6, 2014

Got it with SSH :S and its not my internet/PC fault. Whatever.

Now i got the project I had no idea that i have to do ALL OF THIS: https://code.google.com/p/arduino/wiki/BuildingArduino just to compile arduino. Any other faster way? Only to build and debug the IDE.

Can I somehow create a netbeans project and just debbug the IDE?
PS: Im not an active java programmer.

@matthijskooijman

This comment has been minimized.

Show comment
Hide comment
@matthijskooijman

matthijskooijman Jul 7, 2014

Collaborator

I'm not aware of any faster ways to build. The official repo does not have a Netbeans project and I don't expect anyone else to have published one. Also, there is some post-processing and unpacking of toolchain tarballs that needs to happen, so I'm not sure if Netbeans is up for that.

If you're not otherwise interested in IDE development, feel free to just leave it at this - this pullrequest will move forward even without your test results.

Collaborator

matthijskooijman commented Jul 7, 2014

I'm not aware of any faster ways to build. The official repo does not have a Netbeans project and I don't expect anyone else to have published one. Also, there is some post-processing and unpacking of toolchain tarballs that needs to happen, so I'm not sure if Netbeans is up for that.

If you're not otherwise interested in IDE development, feel free to just leave it at this - this pullrequest will move forward even without your test results.

@andreujuanc

This comment has been minimized.

Show comment
Hide comment
@andreujuanc

andreujuanc Jul 7, 2014

Just wanted to check the IDE without any other thing if necesary.
And yea I know, im not doing this to test the code since I cant even compile it.. And it takes ages to download.

Might not test it.

andreujuanc commented Jul 7, 2014

Just wanted to check the IDE without any other thing if necesary.
And yea I know, im not doing this to test the code since I cant even compile it.. And it takes ages to download.

Might not test it.

@ArduinoBot

This comment has been minimized.

Show comment
Hide comment
@ArduinoBot

ArduinoBot Dec 4, 2014

Contributor

Can one of the admins verify this patch?

Contributor

ArduinoBot commented Dec 4, 2014

Can one of the admins verify this patch?

@ffissore

This comment has been minimized.

Show comment
Hide comment
@ffissore

ffissore May 11, 2015

Contributor

Superseded by #2180

Contributor

ffissore commented May 11, 2015

Superseded by #2180

@ffissore ffissore closed this May 11, 2015

@ffissore ffissore modified the milestone: Release 1.6.5 May 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment