New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the serial monitor to stay opened during upload, disabling it (1.5.x) #2180

Closed
wants to merge 2 commits into
base: ide-1.5.x
from

Conversation

5 participants
@avishorp
Copy link
Contributor

avishorp commented Jul 13, 2014

This request is a re-implementation of #1891 for the 1.5.x branch.

Currently, the serial monitor window closes when starting program uploading. I find this behavior very annoying since the monitor window has to be opened over and over again after each upload. The attached patch fixes this issue. When upload starts, the window gets disabled. When the upload process ends the window gets re-enabled and become operational immediately (if it is visible). The user can also now open the serial monitor window while uploading is in progress.

@avishorp

This comment has been minimized.

Copy link
Contributor

avishorp commented Jul 14, 2014

For those who wish to test the patch, here are precompiled binaries:
linux64
Windows

@cmaglie

This comment has been minimized.

Copy link
Member

cmaglie commented Jul 14, 2014

Please test this on a Leonardo (or other mega32u4 based board), cfr. my comment here:
#1613 (comment)

Related pull requests: #1613 #1891 #1272

@ArduinoBot

This comment has been minimized.

Copy link
Contributor

ArduinoBot commented Aug 22, 2014

Can I build this pull request?

@avishorp

This comment has been minimized.

Copy link
Contributor

avishorp commented Aug 24, 2014

yes

2014-08-22 14:51 GMT+03:00 ArduinoBot notifications@github.com:

Can I build this pull request?


Reply to this email directly or view it on GitHub
#2180 (comment).

@ffissore

This comment has been minimized.

Copy link
Contributor

ffissore commented Aug 25, 2014

@avishorp sorry for the comment from arduinobot. we are setting up automated build of all PRs, so that we can provide a downloadable version of the patched IDE

@ffissore

This comment has been minimized.

Copy link
Contributor

ffissore commented Oct 1, 2014

@ArduinoBot build this please

@ArduinoBot

This comment has been minimized.

Copy link
Contributor

ArduinoBot commented Oct 1, 2014

Merged build finished. Test PASSed.

@ArduinoBot

This comment has been minimized.

Copy link
Contributor

ArduinoBot commented Dec 4, 2014

Can one of the admins verify this patch?

@sampumon

This comment has been minimized.

Copy link

sampumon commented Feb 22, 2015

Hello. Above build works perfect for me. How about merge? 🐳

@ffissore

This comment has been minimized.

Copy link
Contributor

ffissore commented May 11, 2015

Superseded and rebased in #2742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment