Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tools discovery by strictly following json data when available #5199

Merged
merged 7 commits into from
Aug 3, 2016

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Aug 2, 2016

Should fix #5042 and #5168.

(in particular #5168 would need more work to implement my proposal of coreDependencies field into package_index.json to be a complete solution, IMHO)

See also #5197.

/cc @facchinm @PaulStoffregen @matthijskooijman @per1234 @jantje

@per1234
Copy link
Collaborator

per1234 commented Aug 3, 2016

I tested build 584 with the following URLs:
https://raw.githubusercontent.com/MCUdude/MightyCore/b3d9b22f15ec98e5c4ab54741357b941a8338c73/package_MCUdude_MightyCore_index.json

  • toolsDependencies: none
  • tools: none

https://raw.githubusercontent.com/MCUdude/MightyCore/496567391dc35d756e7b8a3f06bce830e8e77131/package_MCUdude_MightyCore_index.json

  • toolsDependencies:
    • avr-gcc 4.8.1-arduino5
    • avrdude 6.0.1-arduino5
  • tools: none

https://raw.githubusercontent.com/per1234/MightyCore/update-tools-dependencies/package_MCUdude_MightyCore_index.json

  • toolsDependencies:
    • avr-gcc 4.9.2-atmel3.5.3-arduino2
    • avrdude 6.3.0-arduino2
  • tools: none

https://raw.githubusercontent.com/per1234/MightyCore/add-tools/package_MCUdude_MightyCore_index.json

https://raw.githubusercontent.com/per1234/MightyCore/add-old-tools/package_MCUdude_MightyCore_index.json

  • toolsDependencies:
    • avr-gcc 4.8.1-arduino5
    • avrdude 6.0.1-arduino5
  • tools:
    • avr-gcc 4.8.1-arduino5
    • avrdude 6.0.1-arduino5

https://raw.githubusercontent.com/per1234/MightyCore/add-new-tools/package_MCUdude_MightyCore_index.json

  • toolsDependencies:
    • avr-gcc 4.9.2-atmel3.5.3-arduino2
    • avrdude 6.3.0-arduino2
  • tools:
    • avr-gcc 4.9.2-atmel3.5.3-arduino2
    • avrdude 6.3.0-arduino2

In all cases the installation proceeded correctly. When the specified tool version was already installed that copy was used. The correct tools were selected for compilation, upload, and Burn Bootloader with MightyCore and Arduino AVR Boards. When a core was updated with a new tool version if the previous tool version was referenced it was left installed, otherwise it was removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arduino IDE selects wrong board package toolchain
4 participants