Added two missing macros to the compatibility pgmspace.h #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some macros were missing from the compatibility header
Update pgmspace.h
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #227 +/- ##
=======================================
Coverage 95.53% 95.53%
=======================================
Files 16 16
Lines 1075 1075
=======================================
Hits 1027 1027
Misses 48 48 ☔ View full report in Codecov by Sentry. |
|
Missing in comparison to ... which other file? In which header file have these macros been previously included? |
|
They are in the original avr/pgmspace.h included with all Arduino IDE 1.x and 2.x installs for avr boards. ref: https://www.nongnu.org/avr-libc/user-manual/group__avr__pgmspace.html |
|
The AVR core doesn't use ArduinoCore-API, however I've tested your change with
and I could not find a regression 👍 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two macros were missing so i added them