use paths.path ad argument in app.load

dido18 · dido18 · commit 8b1426af9b7a · 2025-11-26T11:54:51.000+01:00
diff --git a/cmd/arduino-app-cli/app/app.go b/cmd/arduino-app-cli/app/app.go
@@ -50,5 +50,5 @@ func Load(idOrPath string) (app.ArduinoApp, error) {
 		return app.ArduinoApp{}, fmt.Errorf("invalid app path: %s", idOrPath)
 	}
 
-	return app.Load(id.ToPath().String())
+	return app.Load(id.ToPath())
 }
diff --git a/internal/api/handlers/app_delete.go b/internal/api/handlers/app_delete.go
@@ -42,7 +42,7 @@ func HandleAppDelete(
 			return
 		}
 
-		app, err := app.Load(id.ToPath().String())
+		app, err := app.Load(id.ToPath())
 		if err != nil {
 			slog.Error("Unable to parse the app.yaml", slog.String("error", err.Error()), slog.String("path", id.String()))
 			render.EncodeResponse(w, http.StatusInternalServerError, models.ErrorResponse{Details: "unable to find the app"})
diff --git a/internal/api/handlers/app_details.go b/internal/api/handlers/app_details.go
@@ -45,7 +45,7 @@ func HandleAppDetails(
 			return
 		}
 
-		app, err := app.Load(id.ToPath().String())
+		app, err := app.Load(id.ToPath())
 		if err != nil {
 			slog.Error("Unable to parse the app.yaml", slog.String("error", err.Error()), slog.String("path", id.String()))
 			render.EncodeResponse(w, http.StatusInternalServerError, models.ErrorResponse{Details: "unable to find the app"})
@@ -81,7 +81,7 @@ func HandleAppDetailsEdits(
 			render.EncodeResponse(w, http.StatusPreconditionFailed, models.ErrorResponse{Details: "invalid id"})
 			return
 		}
-		appToEdit, err := app.Load(id.ToPath().String())
+		appToEdit, err := app.Load(id.ToPath())
 		if err != nil {
 			slog.Error("Unable to parse the app.yaml", slog.String("error", err.Error()), slog.String("path", id.String()))
 			render.EncodeResponse(w, http.StatusInternalServerError, models.ErrorResponse{Details: "unable to find the app"})
diff --git a/internal/api/handlers/app_logs.go b/internal/api/handlers/app_logs.go
@@ -43,7 +43,7 @@ func HandleAppLogs(
 			return
 		}
 
-		app, err := app.Load(id.ToPath().String())
+		app, err := app.Load(id.ToPath())
 		if err != nil {
 			slog.Error("Unable to parse the app.yaml", slog.String("error", err.Error()), slog.String("path", id.String()))
 			render.EncodeResponse(w, http.StatusInternalServerError, models.ErrorResponse{Details: "unable to find the app"})
diff --git a/internal/api/handlers/app_ports.go b/internal/api/handlers/app_ports.go
@@ -47,7 +47,7 @@ func HandleAppPorts(
 			return
 		}
 
-		app, err := app.Load(id.ToPath().String())
+		app, err := app.Load(id.ToPath())
 		if err != nil {
 			slog.Error("Unable to parse the app.yaml", slog.String("error", err.Error()), slog.String("path", id.String()))
 			render.EncodeResponse(w, http.StatusInternalServerError, models.ErrorResponse{Details: "unable to find the app"})
diff --git a/internal/api/handlers/app_sketch_libs.go b/internal/api/handlers/app_sketch_libs.go
@@ -36,7 +36,7 @@ func HandleSketchAddLibrary(idProvider *app.IDProvider) http.HandlerFunc {
 			render.EncodeResponse(w, http.StatusBadRequest, models.ErrorResponse{Details: "cannot alter examples"})
 			return
 		}
-		app, err := app.Load(id.ToPath().String())
+		app, err := app.Load(id.ToPath())
 
 		// Get query param addDeps (default false)
 		addDeps, _ := strconv.ParseBool(r.URL.Query().Get("add_deps"))
@@ -78,7 +78,7 @@ func HandleSketchRemoveLibrary(idProvider *app.IDProvider) http.HandlerFunc {
 			render.EncodeResponse(w, http.StatusBadRequest, models.ErrorResponse{Details: "cannot alter examples"})
 			return
 		}
-		app, err := app.Load(id.ToPath().String())
+		app, err := app.Load(id.ToPath())
 		if err != nil {
 			render.EncodeResponse(w, http.StatusInternalServerError, models.ErrorResponse{Details: "unable to find the app"})
 			return
@@ -114,7 +114,7 @@ func HandleSketchListLibraries(idProvider *app.IDProvider) http.HandlerFunc {
 			render.EncodeResponse(w, http.StatusPreconditionFailed, models.ErrorResponse{Details: "invalid id"})
 			return
 		}
-		app, err := app.Load(id.ToPath().String())
+		app, err := app.Load(id.ToPath())
 		if err != nil {
 			render.EncodeResponse(w, http.StatusInternalServerError, models.ErrorResponse{Details: "unable to find the app"})
 			return
diff --git a/internal/api/handlers/app_start.go b/internal/api/handlers/app_start.go
@@ -47,7 +47,7 @@ func HandleAppStart(
 			return
 		}
 
-		app, err := app.Load(id.ToPath().String())
+		app, err := app.Load(id.ToPath())
 		if err != nil {
 			slog.Error("Unable to parse the app.yaml", slog.String("error", err.Error()), slog.String("path", id.String()))
 			render.EncodeResponse(w, http.StatusInternalServerError, models.ErrorResponse{Details: "unable to find the app"})
diff --git a/internal/api/handlers/app_stop.go b/internal/api/handlers/app_stop.go
@@ -38,7 +38,7 @@ func HandleAppStop(
 			return
 		}
 
-		app, err := app.Load(id.ToPath().String())
+		app, err := app.Load(id.ToPath())
 		if err != nil {
 			slog.Error("Unable to parse the app.yaml", slog.String("error", err.Error()), slog.String("path", id.String()))
 			render.EncodeResponse(w, http.StatusInternalServerError, models.ErrorResponse{Details: "unable to find the app"})
diff --git a/internal/api/handlers/bricks.go b/internal/api/handlers/bricks.go
@@ -55,7 +55,7 @@ func HandleAppBrickInstancesList(
 		}
 		appPath := appId.ToPath()
 
-		app, err := app.Load(appPath.String())
+		app, err := app.Load(appPath)
 		if err != nil {
 			slog.Error("Unable to parse the app.yaml", slog.String("error", err.Error()), slog.String("path", appId.String()))
 			render.EncodeResponse(w, http.StatusInternalServerError, models.ErrorResponse{Details: "unable to find the app"})
@@ -85,7 +85,7 @@ func HandleAppBrickInstanceDetails(
 		}
 		appPath := appId.ToPath()
 
-		app, err := app.Load(appPath.String())
+		app, err := app.Load(appPath)
 		if err != nil {
 			slog.Error("Unable to parse the app.yaml", slog.String("error", err.Error()), slog.String("path", appId.String()))
 			render.EncodeResponse(w, http.StatusInternalServerError, models.ErrorResponse{Details: "unable to find the app"})
@@ -120,7 +120,7 @@ func HandleBrickCreate(
 		}
 		appPath := appId.ToPath()
 
-		app, err := app.Load(appPath.String())
+		app, err := app.Load(appPath)
 		if err != nil {
 			slog.Error("Unable to parse the app.yaml", slog.String("error", err.Error()), slog.String("path", appId.String()))
 			render.EncodeResponse(w, http.StatusInternalServerError, models.ErrorResponse{Details: "unable to find the app"})
@@ -190,7 +190,7 @@ func HandleBrickUpdates(
 		}
 		appPath := appId.ToPath()
 
-		app, err := app.Load(appPath.String())
+		app, err := app.Load(appPath)
 		if err != nil {
 			slog.Error("Unable to parse the app.yaml", slog.String("error", err.Error()), slog.String("path", appId.String()))
 			render.EncodeResponse(w, http.StatusInternalServerError, models.ErrorResponse{Details: "unable to find the app"})
@@ -236,7 +236,7 @@ func HandleBrickDelete(
 		}
 		appPath := appId.ToPath()
 
-		app, err := app.Load(appPath.String())
+		app, err := app.Load(appPath)
 		if err != nil {
 			slog.Error("Unable to parse the app.yaml", slog.String("error", err.Error()), slog.String("path", appId.String()))
 			render.EncodeResponse(w, http.StatusInternalServerError, models.ErrorResponse{Details: "unable to find the app"})
diff --git a/internal/orchestrator/app/app.go b/internal/orchestrator/app/app.go
@@ -37,10 +37,10 @@ type ArduinoApp struct {
 
 // Load creates an App instance by reading all the files composing an app and grouping them
 // by file type.
-func Load(appPath string) (ArduinoApp, error) {
-	path := paths.New(appPath)
+// TODO: use the *paths.Path as argument
+func Load(path *paths.Path) (ArduinoApp, error) {
 	if path == nil {
-		return ArduinoApp{}, errors.New("empty app path")
+		return ArduinoApp{}, errors.New("path cannot be empty")
 	}
 
 	exist, err := path.IsDirCheck()
diff --git a/internal/orchestrator/app/app_test.go b/internal/orchestrator/app/app_test.go
@@ -26,26 +26,26 @@ import (
 
 func TestLoad(t *testing.T) {
 	t.Run("it fails if the app path is empty", func(t *testing.T) {
-		app, err := Load("")
+		app, err := Load(nil)
 		assert.Error(t, err)
 		assert.Empty(t, app)
 		assert.Contains(t, err.Error(), "empty app path")
 	})
 
 	t.Run("it fails if the app path exist but it's a file", func(t *testing.T) {
-		_, err := Load("testdata/app.yaml")
+		_, err := Load(paths.New("testdata/app.yaml"))
 		assert.Error(t, err)
 		assert.Contains(t, err.Error(), "app path must be a directory")
 	})
 
 	t.Run("it fails if the app path does not exist", func(t *testing.T) {
-		_, err := Load("testdata/this-folder-does-not-exist")
+		_, err := Load(paths.New("testdata/this-folder-does-not-exist"))
 		assert.Error(t, err)
 		assert.Contains(t, err.Error(), "app path is not valid")
 	})
 
 	t.Run("it loads an app correctly", func(t *testing.T) {
-		app, err := Load("testdata/AppSimple")
+		app, err := Load(paths.New("testdata/AppSimple"))
 		assert.NoError(t, err)
 		assert.NotEmpty(t, app)
 
@@ -61,7 +61,7 @@ func TestMissingDescriptor(t *testing.T) {
 	appFolderPath := paths.New("testdata", "MissingDescriptor")
 
 	// Load app
-	app, err := Load(appFolderPath.String())
+	app, err := Load(appFolderPath)
 	assert.Error(t, err)
 	assert.ErrorContains(t, err, "descriptor app.yaml file missing from app")
 	assert.Empty(t, app)
@@ -71,7 +71,7 @@ func TestMissingMains(t *testing.T) {
 	appFolderPath := paths.New("testdata", "MissingMains")
 
 	// Load app
-	app, err := Load(appFolderPath.String())
+	app, err := Load(appFolderPath)
 	assert.Error(t, err)
 	assert.ErrorContains(t, err, "main python file and sketch file missing from app")
 	assert.Empty(t, app)
diff --git a/internal/orchestrator/app/parser_test.go b/internal/orchestrator/app/parser_test.go
@@ -115,7 +115,7 @@ bricks:
 	err = os.WriteFile(appYaml.String(), []byte(appDescriptor), 0600)
 	require.NoError(t, err)
 
-	app, err := Load(tempDir)
+	app, err := Load(appYaml)
 	require.NoError(t, err)
 	require.Equal(t, "Test App", app.Name)
 	require.Equal(t, 1, len(app.Descriptor.Bricks))
diff --git a/internal/orchestrator/app_status.go b/internal/orchestrator/app_status.go
@@ -97,7 +97,7 @@ func parseDockerStatusEvent(ctx context.Context, cfg config.Configuration, docke
 		}
 
 		// FIXME: create an helper function to transform an app.ArduinoApp into an ortchestrator.AppInfo
-		app, err := app.Load(appStatus.AppPath.String())
+		app, err := app.Load(appStatus.AppPath)
 		if err != nil {
 			slog.Warn("error loading app", "appPath", appStatus.AppPath.String(), "error", err)
 			return AppInfo{}, err
diff --git a/internal/orchestrator/bricks/bricks.go b/internal/orchestrator/bricks/bricks.go
@@ -247,7 +247,7 @@ func getUsedByApps(
 	}
 
 	for _, file := range appPaths {
-		app, err := app.Load(file.String())
+		app, err := app.Load(file)
 		if err != nil {
 			// we are not considering the broken apps
 			slog.Warn("unable to parse app.yaml, skipping", "path", file.String(), "error", err.Error())
diff --git a/internal/orchestrator/bricks/bricks_test.go b/internal/orchestrator/bricks/bricks_test.go
@@ -37,7 +37,7 @@ func TestBrickCreate(t *testing.T) {
 	brickService := NewService(nil, bricksIndex, nil)
 
 	t.Run("fails if brick id does not exist", func(t *testing.T) {
-		err = brickService.BrickCreate(BrickCreateUpdateRequest{ID: "not-existing-id"}, f.Must(app.Load("testdata/dummy-app")))
+		err = brickService.BrickCreate(BrickCreateUpdateRequest{ID: "not-existing-id"}, f.Must(app.Load(paths.New("testdata/dummy-app"))))
 		require.Error(t, err)
 		require.Equal(t, "brick \"not-existing-id\" not found", err.Error())
 	})
@@ -46,7 +46,7 @@ func TestBrickCreate(t *testing.T) {
 		req := BrickCreateUpdateRequest{ID: "arduino:arduino_cloud", Variables: map[string]string{
 			"NON_EXISTING_VARIABLE": "some-value",
 		}}
-		err = brickService.BrickCreate(req, f.Must(app.Load("testdata/dummy-app")))
+		err = brickService.BrickCreate(req, f.Must(app.Load(paths.New("testdata/dummy-app"))))
 		require.Error(t, err)
 		require.Equal(t, "variable \"NON_EXISTING_VARIABLE\" does not exist on brick \"arduino:arduino_cloud\"", err.Error())
 	})
@@ -56,7 +56,7 @@ func TestBrickCreate(t *testing.T) {
 			"ARDUINO_DEVICE_ID": "",
 			"ARDUINO_SECRET":    "a-secret-a",
 		}}
-		err = brickService.BrickCreate(req, f.Must(app.Load("testdata/dummy-app")))
+		err = brickService.BrickCreate(req, f.Must(app.Load(paths.New("testdata/dummy-app"))))
 		require.Error(t, err)
 		require.Equal(t, "required variable \"ARDUINO_DEVICE_ID\" cannot be empty", err.Error())
 	})
@@ -70,10 +70,10 @@ func TestBrickCreate(t *testing.T) {
 		req := BrickCreateUpdateRequest{ID: "arduino:arduino_cloud", Variables: map[string]string{
 			"ARDUINO_SECRET": "a-secret-a",
 		}}
-		err = brickService.BrickCreate(req, f.Must(app.Load(tempDummyApp.String())))
+		err = brickService.BrickCreate(req, f.Must(app.Load(tempDummyApp)))
 		require.NoError(t, err)
 
-		after, err := app.Load(tempDummyApp.String())
+		after, err := app.Load(tempDummyApp)
 		require.Nil(t, err)
 		require.Len(t, after.Descriptor.Bricks, 1)
 		require.Equal(t, "arduino:arduino_cloud", after.Descriptor.Bricks[0].ID)
@@ -88,9 +88,9 @@ func TestBrickCreate(t *testing.T) {
 		require.Nil(t, paths.New("testdata/dummy-app").CopyDirTo(tempDummyApp))
 
 		req := BrickCreateUpdateRequest{ID: "arduino:dbstorage_sqlstore"}
-		err = brickService.BrickCreate(req, f.Must(app.Load(tempDummyApp.String())))
+		err = brickService.BrickCreate(req, f.Must(app.Load(tempDummyApp)))
 		require.Nil(t, err)
-		after, err := app.Load(tempDummyApp.String())
+		after, err := app.Load(tempDummyApp)
 		require.Nil(t, err)
 		require.Len(t, after.Descriptor.Bricks, 2)
 		require.Equal(t, "arduino:dbstorage_sqlstore", after.Descriptor.Bricks[1].ID)
@@ -116,10 +116,10 @@ func TestBrickCreate(t *testing.T) {
 			},
 		}
 
-		err = brickService.BrickCreate(req, f.Must(app.Load(tempDummyApp.String())))
+		err = brickService.BrickCreate(req, f.Must(app.Load(tempDummyApp)))
 		require.Nil(t, err)
 
-		after, err := app.Load(tempDummyApp.String())
+		after, err := app.Load(tempDummyApp)
 		require.Nil(t, err)
 		require.Len(t, after.Descriptor.Bricks, 1)
 		require.Equal(t, "arduino:arduino_cloud", after.Descriptor.Bricks[0].ID)
@@ -134,13 +134,13 @@ func TestUpdateBrick(t *testing.T) {
 	brickService := NewService(nil, bricksIndex, nil)
 
 	t.Run("fails if brick id does not exist into brick index", func(t *testing.T) {
-		err = brickService.BrickUpdate(BrickCreateUpdateRequest{ID: "not-existing-id"}, f.Must(app.Load("testdata/dummy-app")))
+		err = brickService.BrickUpdate(BrickCreateUpdateRequest{ID: "not-existing-id"}, f.Must(app.Load(paths.New("testdata/dummy-app"))))
 		require.Error(t, err)
 		require.Equal(t, "brick \"not-existing-id\" not found into the brick index", err.Error())
 	})
 
 	t.Run("fails if brick is present into the index but not in the app ", func(t *testing.T) {
-		err = brickService.BrickUpdate(BrickCreateUpdateRequest{ID: "arduino:dbstorage_sqlstore"}, f.Must(app.Load("testdata/dummy-app")))
+		err = brickService.BrickUpdate(BrickCreateUpdateRequest{ID: "arduino:dbstorage_sqlstore"}, f.Must(app.Load(paths.New("testdata/dummy-app"))))
 		require.Error(t, err)
 		require.Equal(t, "brick \"arduino:dbstorage_sqlstore\" not found into the bricks of the app", err.Error())
 	})
@@ -149,7 +149,7 @@ func TestUpdateBrick(t *testing.T) {
 		req := BrickCreateUpdateRequest{ID: "arduino:arduino_cloud", Variables: map[string]string{
 			"NON_EXISTING_VARIABLE": "some-value",
 		}}
-		err = brickService.BrickUpdate(req, f.Must(app.Load("testdata/dummy-app")))
+		err = brickService.BrickUpdate(req, f.Must(app.Load(paths.New("testdata/dummy-app"))))
 		require.Error(t, err)
 		require.Equal(t, "variable \"NON_EXISTING_VARIABLE\" does not exist on brick \"arduino:arduino_cloud\"", err.Error())
 	})
@@ -160,7 +160,7 @@ func TestUpdateBrick(t *testing.T) {
 			"ARDUINO_DEVICE_ID": "",
 			"ARDUINO_SECRET":    "a-secret-a",
 		}}
-		err = brickService.BrickUpdate(req, f.Must(app.Load("testdata/dummy-app")))
+		err = brickService.BrickUpdate(req, f.Must(app.Load(paths.New("testdata/dummy-app"))))
 		require.Error(t, err)
 		require.Equal(t, "required variable \"ARDUINO_DEVICE_ID\" cannot be empty", err.Error())
 	})
@@ -174,10 +174,10 @@ func TestUpdateBrick(t *testing.T) {
 		req := BrickCreateUpdateRequest{ID: "arduino:arduino_cloud", Variables: map[string]string{
 			"ARDUINO_SECRET": "a-secret-a",
 		}}
-		err = brickService.BrickUpdate(req, f.Must(app.Load(tempDummyApp.String())))
+		err = brickService.BrickUpdate(req, f.Must(app.Load(tempDummyApp)))
 		require.NoError(t, err)
 
-		after, err := app.Load(tempDummyApp.String())
+		after, err := app.Load(tempDummyApp)
 		require.Nil(t, err)
 		require.Len(t, after.Descriptor.Bricks, 1)
 		require.Equal(t, "arduino:arduino_cloud", after.Descriptor.Bricks[0].ID)
@@ -203,10 +203,10 @@ func TestUpdateBrick(t *testing.T) {
 			},
 		}
 
-		err = brickService.BrickUpdate(req, f.Must(app.Load(tempDummyApp.String())))
+		err = brickService.BrickUpdate(req, f.Must(app.Load(tempDummyApp)))
 		require.Nil(t, err)
 
-		after, err := app.Load(tempDummyApp.String())
+		after, err := app.Load(tempDummyApp)
 		require.Nil(t, err)
 		require.Len(t, after.Descriptor.Bricks, 1)
 		require.Equal(t, "arduino:arduino_cloud", after.Descriptor.Bricks[0].ID)
@@ -231,10 +231,10 @@ func TestUpdateBrick(t *testing.T) {
 			},
 		}
 
-		err = brickService.BrickUpdate(req, f.Must(app.Load(tempDummyApp.String())))
+		err = brickService.BrickUpdate(req, f.Must(app.Load(tempDummyApp)))
 		require.Nil(t, err)
 
-		after, err := app.Load(tempDummyApp.String())
+		after, err := app.Load(tempDummyApp)
 		require.Nil(t, err)
 		require.Len(t, after.Descriptor.Bricks, 1)
 		require.Equal(t, "arduino:arduino_cloud", after.Descriptor.Bricks[0].ID)
diff --git a/internal/orchestrator/helpers.go b/internal/orchestrator/helpers.go
@@ -193,7 +193,7 @@ func getRunningApp(
 	if idx == -1 {
 		return nil, nil
 	}
-	app, err := app.Load(apps[idx].AppPath.String())
+	app, err := app.Load(apps[idx].AppPath)
 	if err != nil {
 		return nil, fmt.Errorf("failed to load running app: %w", err)
 	}
diff --git a/internal/orchestrator/orchestrator.go b/internal/orchestrator/orchestrator.go
@@ -614,7 +614,7 @@ func ListApps(
 	}
 
 	for _, file := range appPaths {
-		app, err := app.Load(file.String())
+		app, err := app.Load(file)
 		if err != nil {
 			result.BrokenApps = append(result.BrokenApps, BrokenAppInfo{
 				Name:  file.Base(),
@@ -956,7 +956,7 @@ func GetDefaultApp(cfg config.Configuration) (*app.ArduinoApp, error) {
 		return nil, nil
 	}
 
-	app, err := app.Load(string(defaultAppPath))
+	app, err := app.Load(paths.New(string(defaultAppPath)))
 	if err != nil {
 		// If the app is not valid, we remove the file
 		slog.Warn("default app is not valid", slog.String("path", string(defaultAppPath)), slog.String("error", err.Error()))
diff --git a/internal/orchestrator/orchestrator_test.go b/internal/orchestrator/orchestrator_test.go

Original file line number	Diff line number	Diff line change
`@@ -50,5 +50,5 @@ func Load(idOrPath string) (app.ArduinoApp, error) {`
`50`	`50`	`return app.ArduinoApp{}, fmt.Errorf("invalid app path: %s", idOrPath)`
`51`	`51`	`}`
`52`	`52`
`53`		`- return app.Load(id.ToPath().String())`
	`53`	`+ return app.Load(id.ToPath())`
`54`	`54`	`}`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ func HandleAppDelete(`
`42`	`42`	`return`
`43`	`43`	`}`
`44`	`44`
`45`		`- app, err := app.Load(id.ToPath().String())`
	`45`	`+ app, err := app.Load(id.ToPath())`
`46`	`46`	`if err != nil {`
`47`	`47`	`slog.Error("Unable to parse the app.yaml", slog.String("error", err.Error()), slog.String("path", id.String()))`
`48`	`48`	`render.EncodeResponse(w, http.StatusInternalServerError, models.ErrorResponse{Details: "unable to find the app"})`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ func HandleAppLogs(`
`43`	`43`	`return`
`44`	`44`	`}`
`45`	`45`
`46`		`- app, err := app.Load(id.ToPath().String())`
	`46`	`+ app, err := app.Load(id.ToPath())`
`47`	`47`	`if err != nil {`
`48`	`48`	`slog.Error("Unable to parse the app.yaml", slog.String("error", err.Error()), slog.String("path", id.String()))`
`49`	`49`	`render.EncodeResponse(w, http.StatusInternalServerError, models.ErrorResponse{Details: "unable to find the app"})`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ func HandleAppPorts(`
`47`	`47`	`return`
`48`	`48`	`}`
`49`	`49`
`50`		`- app, err := app.Load(id.ToPath().String())`
	`50`	`+ app, err := app.Load(id.ToPath())`
`51`	`51`	`if err != nil {`
`52`	`52`	`slog.Error("Unable to parse the app.yaml", slog.String("error", err.Error()), slog.String("path", id.String()))`
`53`	`53`	`render.EncodeResponse(w, http.StatusInternalServerError, models.ErrorResponse{Details: "unable to find the app"})`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ func HandleAppStart(`
`47`	`47`	`return`
`48`	`48`	`}`
`49`	`49`
`50`		`- app, err := app.Load(id.ToPath().String())`
	`50`	`+ app, err := app.Load(id.ToPath())`
`51`	`51`	`if err != nil {`
`52`	`52`	`slog.Error("Unable to parse the app.yaml", slog.String("error", err.Error()), slog.String("path", id.String()))`
`53`	`53`	`render.EncodeResponse(w, http.StatusInternalServerError, models.ErrorResponse{Details: "unable to find the app"})`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ func HandleAppStop(`
`38`	`38`	`return`
`39`	`39`	`}`
`40`	`40`
`41`		`- app, err := app.Load(id.ToPath().String())`
	`41`	`+ app, err := app.Load(id.ToPath())`
`42`	`42`	`if err != nil {`
`43`	`43`	`slog.Error("Unable to parse the app.yaml", slog.String("error", err.Error()), slog.String("path", id.String()))`
`44`	`44`	`render.EncodeResponse(w, http.StatusInternalServerError, models.ErrorResponse{Details: "unable to find the app"})`