refact: use the Load function uniformely in all the yaml loaders
#107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The CLI has 3 YAML loaders for loading
app.yaml,bricks-list.yamlandmodel-lists.yamlbut the API are not uniform.These are the current APIS for each loader:
modelindex.GenerateModelsIndexFromFile(dir *paths.Path) (*ModelsIndex, error)bricksindex.GenerateBricksIndexFromFile(dir *paths.Path) (*BricksIndex, error)app.Load(appPath string) (ArduinoApp, error)Change description
Change the method to load the file as follows:
modelsindex.Load(dir *path.Path)(*ModelsIndex, error)bricksindex.Load(dir *paths.Path) (*BricksIndex, error)app.Load(apppath *paths.Path)(ArduinoApp, error)Additional Notes
Reviewer checklist
main.