From 889683c96a0b22491d16dea376b02bbf657d1908 Mon Sep 17 00:00:00 2001 From: lucarin91 Date: Fri, 31 Oct 2025 12:19:10 +0100 Subject: [PATCH 1/2] feat(board): return adb stdout/err in case of error --- pkg/board/remote/adb/adb.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pkg/board/remote/adb/adb.go b/pkg/board/remote/adb/adb.go index 745ff0af..6efdb1f4 100644 --- a/pkg/board/remote/adb/adb.go +++ b/pkg/board/remote/adb/adb.go @@ -82,12 +82,13 @@ func (a *ADBConnection) Forward(ctx context.Context, localPort int, remotePort i if err != nil { return err } - if err := cmd.RunWithinContext(ctx); err != nil { + if out, err := cmd.RunAndCaptureCombinedOutput(ctx); err != nil { return fmt.Errorf( - "failed to forward ADB port %s to %s: %w", + "failed to forward ADB port %s to %s: %w: %s", local, remote, err, + out, ) } @@ -99,8 +100,8 @@ func (a *ADBConnection) ForwardKillAll(ctx context.Context) error { if err != nil { return err } - if err := cmd.RunWithinContext(ctx); err != nil { - return fmt.Errorf("failed to kill all ADB forwarded ports: %w", err) + if out, err := cmd.RunAndCaptureCombinedOutput(ctx); err != nil { + return fmt.Errorf("failed to kill all ADB forwarded ports: %w: %s", err, out) } return nil } From f24515ef8c11fdcfe65810aec5d45227e52d2c7d Mon Sep 17 00:00:00 2001 From: lucarin91 Date: Mon, 3 Nov 2025 09:46:22 +0100 Subject: [PATCH 2/2] trigger ci