Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect syntax coloring for Boolean literals #291

Closed
kittaakos opened this issue Mar 31, 2021 · 6 comments · Fixed by #352
Closed

Incorrect syntax coloring for Boolean literals #291

kittaakos opened this issue Mar 31, 2021 · 6 comments · Fixed by #352
Labels
conclusion: resolved Issue was resolved criticality: high Of high impact topic: code Related to content of the project itself topic: theme Related to GUI theming type: imperfection Perceived defect in any part of project

Comments

@kittaakos
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

true and false have incorrect syntax coloring:

Java IDE:
Screen Shot 2021-03-31 at 13 24 01

New IDE:
Screen Shot 2021-03-31 at 13 23 53
@Macka323
Copy link

Macka323 commented Apr 1, 2021

I don't know if this isn't the problem or I have different version or something else but the syntax coloring is correct.
image

@kittaakos
Copy link
Contributor Author

the syntax coloring is correct.

No, it isn't. I am comparing the Java IDE and the new IDE bahevior.

Screen Shot 2021-04-01 at 12 49 40
Screen Shot 2021-04-01 at 12 49 45

@Macka323
Copy link

Macka323 commented Apr 1, 2021 •
edited

Maybe I am wrong, I don't know, I am beginner and trying to contribute
image

@ubidefeo
Copy link

ubidefeo commented Apr 1, 2021

@kittaakos I have tried and it only lacks colouring on the Light Arduino theme
the dark theme shows it correctly.
@Macka323 can you try the Light Arduino theme?

Light Arduino
Screenshot 2021-04-01 at 22 46 55

Light Theia
Screenshot 2021-04-01 at 22 49 21

Dark Theia
Screenshot 2021-04-01 at 22 48 59

@ubidefeo ubidefeo added the priority: medium Resolution is a medium priority label Apr 1, 2021
@Macka323
Copy link

Macka323 commented Apr 2, 2021

@ubidefeo The syntax coloring in the Light Arduino is wrong.

@ubidefeo
Copy link

ubidefeo commented Apr 4, 2021

thank you for confirming this.
definitely a bug :)

@ubidefeo ubidefeo added priority: high Resolution is a high priority and removed priority: medium Resolution is a medium priority labels Apr 6, 2021
@fstasi fstasi mentioned this issue May 4, 2021
Merged
This was referenced Jun 3, 2021
Closed
Closed
@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
@per1234 per1234 added topic: code Related to content of the project itself topic: theme Related to GUI theming conclusion: resolved Issue was resolved labels Oct 25, 2021
@rsora rsora added criticality: high Of high impact and removed priority: high Resolution is a high priority labels Nov 2, 2021
@per1234 per1234 mentioned this issue Mar 6, 2022
Closed
@per1234 per1234 changed the title Incorrect bool syntax coloring Incorrect syntax coloring for Boolean literals Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
conclusion: resolved Issue was resolved criticality: high Of high impact topic: code Related to content of the project itself topic: theme Related to GUI theming type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ATL-1222] fix editor colors arduino/arduino-ide
5 participants
@kittaakos @ubidefeo @per1234 @rsora @Macka323