Skip to content

Add library of LM35, LM35A #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from Nov 9, 2022
Merged

Add library of LM35, LM35A #2080

merged 14 commits into from Nov 9, 2022

Conversation

ghost
Copy link

@ghost ghost commented Nov 9, 2022

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Nov 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

Arduino Lint has suggestions for possible improvements to https://github.com/RLL-Blue-Dragon/OSS-EC_TI_LM35_LM35A_00000057:

Linting library in OSS-EC_TI_LM35_LM35A_00000057
INFO: No header file found matching library name (OSS-EC_TI_LM35_LM35A_00000057.h). Best practices are for primary      
      header filename to match library name.                                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: Potentially misspelled library.properties field name detected.                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP006)                                                                                          
WARNING: library.properties name value OSS-EC_TI_LM35_LM35A_00000057 is longer than the recommended length of 16        
         characters.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP010)                                                                                                   
WARNING: library.properties depends field item(s) analogReference analogRead not found in the Library Manager index.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format     
         (Rule LP048)                                                                                               
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 0 ERRORS, 4 WARNINGS

-------------------

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

ERROR: Your submission meets all requirements. However, the pull request could not be merged.

Please follow this guide to resolve a merge conflict:
https://docs.github.com/github/collaborating-with-issues-and-pull-requests/resolving-a-merge-conflict-on-github

Once that is done, it will be merged automatically.

@github-actions github-actions bot requested a review from per1234 November 9, 2022 02:07
@github-actions github-actions bot removed the request for review from per1234 November 9, 2022 02:10
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

Arduino Lint has suggestions for possible improvements to https://github.com/RLL-Blue-Dragon/OSS-EC_TI_LM35_LM35A_00000057:

Linting library in OSS-EC_TI_LM35_LM35A_00000057
INFO: No header file found matching library name (OSS-EC_TI_LM35_LM35A_00000057.h). Best practices are for primary      
      header filename to match library name.                                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: Potentially misspelled library.properties field name detected.                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP006)                                                                                          
WARNING: library.properties name value OSS-EC_TI_LM35_LM35A_00000057 is longer than the recommended length of 16        
         characters.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP010)                                                                                                   
WARNING: library.properties depends field item(s) analogReference analogRead not found in the Library Manager index.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format     
         (Rule LP048)                                                                                               
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 0 ERRORS, 4 WARNINGS

-------------------

@github-actions github-actions bot merged commit de5bb34 into arduino:main Nov 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/RLL-Blue-Dragon/OSS-EC_TI_LM35_LM35A_00000057/

github-actions bot pushed a commit that referenced this pull request Nov 9, 2022
@per1234
Copy link
Contributor

per1234 commented Nov 9, 2022

@RLL-Blue-Dragon please take the time to very carefully review the warnings from the bot. You are creating many libraries with the same problems. It will be best for you to break that pattern as early as possible because it will more work to fix all these problems retroactively.


This one is very serious:

WARNING: library.properties depends field item(s) analogReference analogRead not found in the Library Manager index.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format     
         (Rule LP048)                                                                                               

This problem will make it impossible for people to install your libraries via Library Manager. So what is the point of adding all these libraries if they can't even be installed?

Please take the time to carefully study the documentation to understand the correct use of the depends field:

https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format


This one is just plain sloppy:

WARNING: Potentially misspelled library.properties field name detected.                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP006)                                                                                          

Again, please take the time to study the documentation and correctly format your metadata:

https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format


And of course we have this:

WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)  

I see you have a sketch named sample in the root of the repository. This is not the correct way to provide an example sketch. Please take the time to study the documentation so you can understand the correct way to provide example sketches:

https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant