Skip to content

Add xmodem library #2657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Add xmodem library #2657

merged 1 commit into from
Apr 7, 2023

Conversation

gilman88
Copy link
Contributor

@gilman88 gilman88 commented Apr 7, 2023

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Apr 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

Arduino Lint has suggestions for possible improvements to https://github.com/gilman88/xmodem-lib:

Linting library in xmodem-lib
INFO: No header file found matching library name (XModem_transfer_library.h). Best practices are for primary header     
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: Potentially misspelled extras folder name found: xmodem-lib/extra                           
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#extra-documentation
         (Rule LS011)                                                                                
WARNING: library.properties name value XModem transfer library is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format       
         (Rule LP010)                                                                                                 
WARNING: library.properties name XModem transfer library contains spaces. Although supported, best practices is to not  
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Library name XModem transfer library contains "library". This is superfluous.                         
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP016)                                                                                          

Linter results for project: 0 ERRORS, 4 WARNINGS

-------------------

Linting sketch in xmodem-lib/examples/Basic_Receive
WARNING: Sketch file/folder name mismatch. The primary sketch file name must match the folder: Basic_Receive.ino
         See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#primary-sketch-file            
         (Rule SS001)                                                                                           

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in xmodem-lib/examples/Basic_Send
WARNING: Sketch file/folder name mismatch. The primary sketch file name must match the folder: Basic_Send.ino
         See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#primary-sketch-file         
         (Rule SS001)                                                                                        

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linter results for projects: 0 ERRORS, 6 WARNINGS

@github-actions github-actions bot merged commit 85d1bf7 into arduino:main Apr 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/gilman88/xmodem-lib/

github-actions bot pushed a commit that referenced this pull request Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant