Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix model resolved in getModulePermalinkBase #1216

Merged
merged 2 commits into from Oct 29, 2021
Merged

fix model resolved in getModulePermalinkBase #1216

merged 2 commits into from Oct 29, 2021

Conversation

bwat-dev
Copy link
Contributor

Check if the model class exist in the capsule

pboivin
pboivin previously approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@pboivin pboivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @bwat-dev. One quick question below.

src/Http/Controllers/Admin/ModuleController.php Outdated Show resolved Hide resolved
@pboivin pboivin merged commit 21a4248 into area17:2.x Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pboivin pboivin pboivin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bwat-dev @pboivin