Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aredn: remove duplicate file and minify #109

Merged
merged 1 commit into from Aug 4, 2018

Conversation

@r1de
Copy link
Contributor

commented Aug 4, 2018

I found a duplicated file in www, only 16k, but every bit matters now.
Removed the duplicate and replaced the file with a minified version.
Updated www/cgi-bin/scan to use new minified file.
Tested. works fine.

aredn: remove duplicate file and minify
I found a duplicated file in www, only 16k, but every bit matters now.
Removed the duplicate and the replaced the file with a  minified version.
Updated www/cgi-bin/scan to use new minified file.
Tested. works fine.
@ae6xe
Copy link
Contributor

left a comment

the issue is long term maintainability. Darryl, interested in your comments -- didn't you write this? Looks like one version is the 'maintainable' copy used to generate the mini by removing unnecessary chars for run time. Is there a way to consolidate to the maintainable version, then at run time strip the unnecessary chars to send to the client browser? (Is this the reason there is a 'mini')?

@dman776

This comment has been minimized.

Copy link
Contributor

commented Aug 4, 2018

@ae6xe
ae6xe approved these changes Aug 4, 2018

@ae6xe ae6xe merged commit 683c7b7 into aredn:develop Aug 4, 2018

@r1de r1de deleted the r1de:removeDupeFile branch Aug 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.