Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aredn: Prepare 3.18.09.0RC1 for release #196

Merged
merged 1 commit into from Sep 22, 2018

Conversation

@ae6xe
Copy link
Contributor

commented Sep 22, 2018

No description provided.

@ae6xe ae6xe requested a review from dman776 Sep 22, 2018

config.mk Outdated
MAKE_ARGS=-j3

# Where will the installed image find add-on Packages to download?
# This URL must contain the packages from this build
# downloading packages within the AREDN UI uses signatures
PRIVATE_BUILD_PACKAGES=http://downloads.arednmesh.org/snapshots/trunk
PRIVATE_BUILD_PACKAGES=http://downloads.arednmesh.org/releases/3/18/3.18.09.0

This comment has been minimized.

Copy link
@dman776

dman776 Sep 22, 2018

Contributor

remove the leading 0

@@ -1084,25 +1084,25 @@ sub hardware_info
},
'0xc302' => {
'name' => 'PicoStation2',
'comment' => 'PicoStation2 (NOT M series) in testing',

This comment has been minimized.

Copy link
@dman776

dman776 Sep 22, 2018

Contributor

the non-M series should not be supported

This comment has been minimized.

Copy link
@ae6xe

ae6xe Sep 22, 2018

Author Contributor

The picostation 2 has 8MB flash and 32Mb RAM. I thought it did work. "not M series" because it is the "M" series that is the issue --only have 4MB flash and no way to install. (all the stuff we support is "M2").

This comment has been minimized.

Copy link
@dman776

dman776 Sep 22, 2018

Contributor

It's never been on the SPM. Only the PS M2

This comment has been minimized.

Copy link
@ae6xe

ae6xe Sep 22, 2018

Author Contributor

OK, let me take it out until we can confirm it works.

'maxpower' => '16',
'pwroffset' => '4',
'usechains' => 0,
'rfband' => '2400',
},
'0xc3a2' => {
'name' => 'PicoStation2 HP',
'comment' => 'PicoStation2 HP (NOT M series) in testing',

This comment has been minimized.

Copy link
@dman776

dman776 Sep 22, 2018

Contributor

the non-M series should not be supported

@ae6xe ae6xe force-pushed the ae6xe:rc1 branch 2 times, most recently from 6ca0595 to 5282ff7 Sep 22, 2018

@ae6xe ae6xe force-pushed the ae6xe:rc1 branch from 5282ff7 to 2e5f66c Sep 22, 2018

@ae6xe

This comment has been minimized.

Copy link
Contributor Author

commented Sep 22, 2018

Updates made. Note the comment usage was inconsistent. Many had no comment, some had a comment with same information as the name. Unless the comment was different than the name and added more information, it is now empty.

@dman776
Copy link
Contributor

left a comment

Looks good

@ae6xe ae6xe merged commit c622140 into aredn:develop Sep 22, 2018

@ae6xe ae6xe deleted the ae6xe:rc1 branch Nov 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.