Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Provide firmware file advice for uploading firmware files #217

Merged
merged 4 commits into from Oct 10, 2018

Conversation

dman776
Copy link
Contributor

@dman776 dman776 commented Oct 4, 2018

also reduces page size by removing unnecessary style info on option tags.

fixes #206

also reduces page size by removing unnecessary style info on option tags.

fixes #206
@dman776 dman776 added the enhancement New feature or request label Oct 4, 2018
@dman776 dman776 requested review from ae6xe, wu2s and K6AH October 4, 2018 15:47
Copy link
Contributor

@wu2s wu2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ae6xe
Copy link
Contributor

ae6xe commented Oct 4, 2018

I can test on several of the devices I have. Any I should skip that you've already tested on?

@dman776
Copy link
Contributor Author

dman776 commented Oct 4, 2018 via email

@ae6xe
Copy link
Contributor

ae6xe commented Oct 5, 2018

image

@ae6xe
Copy link
Contributor

ae6xe commented Oct 5, 2018

The hap ac lite images (all the mikrotik images) aren't very nicely named. There's nothing about the model # in the filename. In this case the correct image is:
aredn-3.18.9.0-mikrotik-rb-nor-flash-16M-ac-sysupgrade.bin

The above error was given in trying to load the correct name. The tp-link devices have similar issue.

@ae6xe
Copy link
Contributor

ae6xe commented Oct 6, 2018

Tested successfully on hAP ac lite and basebox 5.

@ae6xe
Copy link
Contributor

ae6xe commented Oct 6, 2018

issue on cpe210v2:
image

@dman776
Copy link
Contributor Author

dman776 commented Oct 6, 2018 via email

@ae6xe
Copy link
Contributor

ae6xe commented Oct 6, 2018

get_hardware_mfg, get_boardid, and get_model all return:
TP-Link CPE210 v2.0

@ae6xe
Copy link
Contributor

ae6xe commented Oct 6, 2018

on cpe510 v1.1:
get_hardware_mfg = TP-Link
get_hardwaretype = cpe510
get_model = TP-Link CPE510 v1.1
get_boardid = TP-Link CPE510 v1.1

@dman776 dman776 merged commit 7a18179 into aredn:develop Oct 10, 2018
@dman776 dman776 deleted the fw_load_advice branch October 10, 2018 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants