Script tag parsing, issue #26 #31

merged 1 commit into from Jun 29, 2011


None yet
2 participants

codders commented Jun 29, 2011

In reference to our discussion earlier, here's a patch in the HTML5 parser that delays emitting the Script tag until it's complete. Didn't seem like JSDom had much control over the tag emission in this case.

It needs some tests, but please let me know if you think it's going in the wrong direction. Good news is, it seems to solve my issue with Zombie.


aredridel commented Jun 29, 2011

Wow. That's really fantastic. Thank you! I'll add you to the contributors list and push out a new version! The jsdom-interaction-free approach works well, there, it looks like.

@aredridel aredridel added a commit that referenced this pull request Jun 29, 2011

@aredridel aredridel Merge pull request #31 from codders/master
Script tag parsing, issue #26

Buffers script tag CDATA until the close tag appears, adding it to the DOM in one piece so that jsdom can execute it at that moment.

@aredridel aredridel merged commit fb4cd01 into aredridel:master Jun 29, 2011

@aredridel aredridel pushed a commit that referenced this pull request Jan 26, 2014

@gsnedders gsnedders Fix #31: remove sites directory.
It's not clear quite why these are here, and they certainly aren't testcases
per-se (what's their pass condition?!). I think originally to have some sort
of shared files for testing performance on? It also seems unlikely we have
the copyright holders' permission to distribute them under the MIT license in
the case of the Google results and the Python docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment