Fixed the "checkin" method #1

Merged
merged 2 commits into from Jan 16, 2013

Projects

None yet

2 participants

@garrettpatterson

Looks like most the library is just for reading and/or GET routes. I've added functionality for POST requests, all for the sake of getting the checkin method to work. Other routes using POST will need to be updated.

  • function param was misspelled
  • turned "get" into "req"
  • created new "get" and "post" functions
  • post adds a "data" field to send post-body form data

I'll keep you updated on any other changes, eventually I'll revisit some of the OAUTH stuff, I thought lack of POST functionality warranted a pull request!

Thanks for starting/maintaining this library

@arei
Owner
arei commented Jan 16, 2013

Doh! I cannot believe I missed that a handful of these end points were supposed to be posts. Thank you for fixing that. Really appreciate the changes.

I had some plan to replace the req function with mikeal's Request module at some point and this might be the inspiration for getting that done.

@arei arei merged commit e94d647 into arei:master Jan 16, 2013
@arei
Owner
arei commented Jan 16, 2013

In fact, I just went in and fixed the remaining ones that were supposed to be POSTs. Thanks for the incentive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment