Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stringification of hstores containing backslash #3

Open
brendanlong opened this issue Dec 21, 2017 · 3 comments
Open

Fix stringification of hstores containing backslash #3

brendanlong opened this issue Dec 21, 2017 · 3 comments
Labels

Comments

@brendanlong
Copy link
Contributor

When working on the Pgx.Value tests I found that converting an hstore containing a backslash to a string and back lost the backlash. Presumably either the stringification code needs to add an extra backslash or the parsing code needs to not remove it.

Also update test_pgx_value.ml with an hstore containing a backslash so we can go up to 100% coverage in that file.

@kevinqiu
Copy link

Is this still valid? I would like to start looking at it. I'll avoid assigning to myself in case I don't actually get started but I'll link any ongoing work and assign once I do.

@brendanlong
Copy link
Contributor Author

I think this is still a real bug. I'd start by creating a test case to be sure.

@brendanlong
Copy link
Contributor Author

I think this is the same bug as #40. We should probably add a test for this case specifically when we fix it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants