Skip to content

Hardcoding light_scheme numbers in xdrv_light.ino feels like a bug #1463

@alexjoni

Description

@alexjoni

There are several places in xdrv_light.ino where max_scheme is calculated from LS_MAX +7
This has bitten me, as I tried adding another scheme - but having to change the code in 2-3 places.

Proposal: replace the +7 with a proper #define or an #enum like for LS_MAX.
I'm happy to submit a patch, if a way is preferred
(I added an enum in sonoff.h so far, but a define would also work).

this is only valid for WS2812

Metadata

Metadata

Assignees

No one assigned

    Labels

    staleAction - Issue left behind - Used by the BOT to call for attention

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions