Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong Dimmer behavior introduced with #6799 when SetOption37 < 128 #6819

Merged
merged 1 commit into from Nov 2, 2019

Conversation

s-hadinger
Copy link
Collaborator

@s-hadinger s-hadinger commented Nov 2, 2019

Description:

Bug reported by @blakadder on Discord.

Now Dimmer has the following behavior:

  • If SetOption37 < 128 (default behavior), RGB and White are linked, i.e. only one of both can be On at the same time. Dimmer has the same behavior as before, it will change the dimmer value for the current mode, either RGB or White.
  • If SetOption37 >= 128 (also called unlinked), RGB and White/CWWW are treated as two independant channels. Dimmer or Dimmer1 will change the Dimmer for RGB. Dimmer2 will change the Dimmer for white(s). Dimmer0 will change both Dimmers at once.

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on core pre-2.6
  • The code change pass travis tests. Your PR cannot be merged unless tests pass
  • I accept the CLA.

@arendst arendst merged commit 99bdd1f into arendst:development Nov 2, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants