Fix wrong Dimmer behavior introduced with #6799 when SetOption37 < 128 - #6819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Bug reported by @blakadder on Discord.
Now
Dimmerhas the following behavior:SetOption37< 128 (default behavior), RGB and White are linked, i.e. only one of both can be On at the same time.Dimmerhas the same behavior as before, it will change the dimmer value for the current mode, either RGB or White.SetOption37>= 128 (also called unlinked), RGB and White/CWWW are treated as two independant channels.DimmerorDimmer1will change the Dimmer for RGB.Dimmer2will change the Dimmer for white(s).Dimmer0will change both Dimmers at once.Checklist: