Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer support for no-sunset permanent day #9543

Merged
merged 1 commit into from Oct 15, 2020

Conversation

cybermaus
Copy link
Contributor

Description:

Related issue (if applicable): fixes #9539

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.3
  • The code change is tested and works on core ESP32 V.1.12.2
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@cybermaus
Copy link
Contributor Author

Seemed to cost 80bytes code. Which is a lot for those few if statements. Maybe some unfortunate word alignments is involved?

Anyway, I think I can marginally reduce code by merging the random-window calculation into the ApplyTimerOffset() function, as it would deduplicate 00h00&24h00 border checks. It would also add support for random offsets to cross midnight.

@arendst arendst merged commit 83d73a4 into arendst:development Oct 15, 2020
@ascillato2 ascillato2 added the hacktoberfest-accepted Type - Issue approved for Hacktoberfest Challenge label Oct 21, 2020
@cybermaus cybermaus mentioned this pull request Oct 25, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Type - Issue approved for Hacktoberfest Challenge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sunset/sunrise in permanent daylight trigger at 20h19
3 participants