Skip to content

[Supergrafx] Daimakaimura (J): Graphical errors in intro #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shideravan opened this issue Aug 8, 2021 · 6 comments
Open

[Supergrafx] Daimakaimura (J): Graphical errors in intro #47

Shideravan opened this issue Aug 8, 2021 · 6 comments
Labels
core-pce PC-Engine / Turbografx, CD, SuperGrafx

Comments

@Shideravan
Copy link
Contributor

image

Version used: 409ea8d
Windows 10 x64

@Shideravan Shideravan changed the title [Supergrafx] Daimakaimura (j): Graphical erros in intro [Supergrafx] Daimakaimura (J): Graphical erros in intro Aug 8, 2021
@Kawa-oneechan Kawa-oneechan changed the title [Supergrafx] Daimakaimura (J): Graphical erros in intro [Supergrafx] Daimakaimura (J): Graphical errors in intro Aug 9, 2021
@LukeUsher LukeUsher added the core-pce PC-Engine / Turbografx, CD, SuperGrafx label Feb 18, 2022
@HeroponRikiBestest
Copy link
Collaborator

Worth noting, this just seems to be an issue with the scanline renderer, it appears correct on pixel accuracy mode.
image

@remutro
Copy link
Contributor

remutro commented Mar 25, 2023

Per invertego: there are some registers that are only implemented in the dot renderer that need to be implemented in the scanline renderer as well.

@invertego
Copy link
Contributor

I could be mistaken because I don't have my notes in front of me, but a quick glance at the code indicates that the VDC HSR (horizontal sync) register is the main culprit here. The performance renderer doesn't model its side effects.

@Shideravan
Copy link
Contributor Author

Seems fixed at v134

@LukeUsher
Copy link
Member

@Shideravan please test properly when closing issues: this is still an issue with the scanline renderer as it always has been.

@LukeUsher LukeUsher reopened this Nov 30, 2023
@Shideravan
Copy link
Contributor Author

@Shideravan please test properly when closing issues: this is still an issue with the scanline renderer as it always has been.

Sorry, I wasn't aware (or I just forget) that changing the settings and resetting the game weren't enough to actually change their state.
Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-pce PC-Engine / Turbografx, CD, SuperGrafx
Development

No branches or pull requests

5 participants