Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize v4 update #129

Closed
wants to merge 7 commits into from
Closed

Finalize v4 update #129

wants to merge 7 commits into from

Conversation

@nilbus
Copy link
Contributor

nilbus commented Aug 19, 2015

This branch is based on #114 frodrigo:v4, with two fixes:

  1. Fix rake update-select2 to work with the new v4 files and locales
  2. Update locale assets via rake update-select2

I have tested this branch in a real app, and it works great.
Things are simpler now that v4 has no images.

@frodrigo set the version number to 4.0.0, but feel free to change to 4.0.0.0 if you
think that will be more consistent.

frodrigo and others added 7 commits Mar 3, 2015
It was still calling SourceFile#convert, which has been removed.
SourceFile#convert is no longer necessary, because select2 4.0.0 no longer uses
image assets.
These assets had not been updated since beta2.

Note that languages ja and ms are *not* present in select2 4.0.0 but will be present
in the next release (because they are currently in master).
@nilbus
Copy link
Contributor Author

nilbus commented Aug 19, 2015

@simi @argerim Will it be possible for you to test and release this today or this week? If anything needs to be done to make this happen, I will be glad to assist.

@simi simi self-assigned this Aug 19, 2015
@nilbus
Copy link
Contributor Author

nilbus commented Aug 25, 2015

@simi I saw you self-assigned this. Any feedback?

@simi
Copy link
Collaborator

simi commented Aug 25, 2015

Sure. But I need to finish review first. This is huge change.

@nilbus
Copy link
Contributor Author

nilbus commented Aug 25, 2015

Thanks :)

@nilbus
Copy link
Contributor Author

nilbus commented Sep 1, 2015

@simi How's it looking? Any progress this week?

@gomayonqui
Copy link

gomayonqui commented Sep 4, 2015

Any plans to merge this soon? 😃

@gomayonqui
Copy link

gomayonqui commented Sep 8, 2015

I'm using @nilbus fork and it works pretty good. Any reason this haven't been merge yet?

@nilbus
Copy link
Contributor Author

nilbus commented Sep 8, 2015

@simi One less-arduous way you might approach this review is to:

  1. Inspect the updated rake task to verify you think it does the right thing.
  2. Run the rake task, and verify that it updates the files in the same way that were committed.
@erkaun
Copy link

erkaun commented Sep 11, 2015

I don't have any suggestions for streamlining what looks like a ton of review work, but just wanted to mention that I've had great results with this so far, and would like this released even more than I'd like a large block of cheese. And I love cheese.

@simi
Copy link
Collaborator

simi commented Sep 11, 2015

It is merged into master. Thanks for your patience and work! I try to release ASAP, but I have not permission for that. Stay tuned.

@simi simi closed this Sep 11, 2015
@nilbus
Copy link
Contributor Author

nilbus commented Sep 11, 2015

@simi Thank you for the review!

@erkaun
Copy link

erkaun commented Sep 15, 2015

@argerim, do you have an estimate on when this update to master will be released?

@simi
Copy link
Collaborator

simi commented Sep 15, 2015

@erkaun it is out.

@nilbus
Copy link
Contributor Author

nilbus commented Sep 15, 2015

Thanks @simi for working to make this happen! 🏁

@erkaun
Copy link

erkaun commented Sep 16, 2015

Thanks @simi and @nilbus! This is very much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.