-
Notifications
You must be signed in to change notification settings - Fork 374
Finalize v4 update #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize v4 update #129
Conversation
It was still calling SourceFile#convert, which has been removed. SourceFile#convert is no longer necessary, because select2 4.0.0 no longer uses image assets.
These assets had not been updated since beta2. Note that languages ja and ms are *not* present in select2 4.0.0 but will be present in the next release (because they are currently in master).
@simi I saw you self-assigned this. Any feedback? |
Sure. But I need to finish review first. This is huge change. |
Thanks :) |
@simi How's it looking? Any progress this week? |
Any plans to merge this soon? 😃 |
I'm using @nilbus fork and it works pretty good. Any reason this haven't been merge yet? |
@simi One less-arduous way you might approach this review is to:
|
I don't have any suggestions for streamlining what looks like a ton of review work, but just wanted to mention that I've had great results with this so far, and would like this released even more than I'd like a large block of cheese. And I love cheese. |
It is merged into master. Thanks for your patience and work! I try to release ASAP, but I have not permission for that. Stay tuned. |
@simi Thank you for the review! |
@argerim, do you have an estimate on when this update to master will be released? |
@erkaun it is out. |
Thanks @simi for working to make this happen! 🏁 |
This branch is based on #114 frodrigo:v4, with two fixes:
I have tested this branch in a real app, and it works great.
Things are simpler now that v4 has no images.
@frodrigo set the version number to 4.0.0, but feel free to change to 4.0.0.0 if you
think that will be more consistent.