From 6e017d46289c7cd7d60da22ec581edcda916179b Mon Sep 17 00:00:00 2001
From: leiyre <leire@recogn.ai>
Date: Mon, 28 Mar 2022 17:31:58 +0200
Subject: [PATCH] feat(#1144): allow all labels deselection in weak supervision
 (#1326)

closes #1144
---
 .../text-classifier/labeling-rules/RuleDefinition.vue      | 7 ++-----
 .../labeling-rules/RuleLabelsDefinition.vue                | 2 +-
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/frontend/components/text-classifier/labeling-rules/RuleDefinition.vue b/frontend/components/text-classifier/labeling-rules/RuleDefinition.vue
index f943086f2a..f0920b7356 100644
--- a/frontend/components/text-classifier/labeling-rules/RuleDefinition.vue
+++ b/frontend/components/text-classifier/labeling-rules/RuleDefinition.vue
@@ -61,10 +61,7 @@ export default {
   },
   watch: {
     async query(newValue) {
-      await this.updateCurrentRule({
-        query: newValue,
-        labels: (this.currentRule || {}).labels,
-      });
+      await this.dataset.setCurrentLabelingRule({ query: newValue });
     },
   },
   computed: {
@@ -103,7 +100,7 @@ export default {
       } else {
         await this.dataset.setCurrentLabelingRule({
           query,
-          labels: undefined,
+          labels: [],
         });
       }
       this.saved = false;
diff --git a/frontend/components/text-classifier/labeling-rules/RuleLabelsDefinition.vue b/frontend/components/text-classifier/labeling-rules/RuleLabelsDefinition.vue
index e197fa6a16..3b0e46e962 100644
--- a/frontend/components/text-classifier/labeling-rules/RuleLabelsDefinition.vue
+++ b/frontend/components/text-classifier/labeling-rules/RuleLabelsDefinition.vue
@@ -153,7 +153,7 @@ export default {
       if (this.selectedLabels && queryWithLabelsIsStored) {
         return `This query with ${
           this.selectedLabels.length > 1 ? "these labels" : "this label"
-        } are already saved as rule`;
+        } is already saved as rule`;
       }
     },
     coveredRecords() {