From fdbc2bc08200f7ab9a392daa626d4eb0ed9855cb Mon Sep 17 00:00:00 2001 From: leire Date: Wed, 16 Nov 2022 10:26:53 +0100 Subject: [PATCH 1/4] fix: Remove "Help explain button" in Manage rule view closes #1807 This PR removes the help explain button from the rules list view --- .../text-classifier/header/TextClassificationHeader.vue | 8 +++++++- .../components/text-classifier/results/RecordExplain.vue | 4 +++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/frontend/components/text-classifier/header/TextClassificationHeader.vue b/frontend/components/text-classifier/header/TextClassificationHeader.vue index 77a3060888..5f6b70cade 100644 --- a/frontend/components/text-classifier/header/TextClassificationHeader.vue +++ b/frontend/components/text-classifier/header/TextClassificationHeader.vue @@ -23,7 +23,10 @@ > - + Date: Wed, 16 Nov 2022 11:15:29 +0100 Subject: [PATCH 2/4] prevent undefined --- .../text-classifier/header/TextClassificationHeader.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/components/text-classifier/header/TextClassificationHeader.vue b/frontend/components/text-classifier/header/TextClassificationHeader.vue index 5f6b70cade..b850518dc8 100644 --- a/frontend/components/text-classifier/header/TextClassificationHeader.vue +++ b/frontend/components/text-classifier/header/TextClassificationHeader.vue @@ -63,7 +63,7 @@ export default { return this.dataset.isMultiLabel; }, isRuleListView() { - return this.dataset.viewSettings.visibleRulesList; + return this.dataset.viewSettings?.visibleRulesList || false; }, availableLabels() { const record = this.dataset.results.records[0]; From 272812510c2f780192468e3f68bfb54bc6f32be9 Mon Sep 17 00:00:00 2001 From: leire Date: Wed, 16 Nov 2022 11:16:01 +0100 Subject: [PATCH 3/4] compute data --- .../text-classifier/results/RecordExplain.vue | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/frontend/components/text-classifier/results/RecordExplain.vue b/frontend/components/text-classifier/results/RecordExplain.vue index 01ab03a845..c8ae6b12d1 100644 --- a/frontend/components/text-classifier/results/RecordExplain.vue +++ b/frontend/components/text-classifier/results/RecordExplain.vue @@ -41,6 +41,11 @@ export default { type: Array, }, }, + data() { + return { + colorSensitivity: 1 // color sensitivity (values from 1 to 4) + } + }, computed: { predicted() { return this.record.predicted; @@ -60,10 +65,8 @@ export default { let percent = Math.round(Math.abs(grad) * 100); if (percent !== 0) { /* eslint-disable no-mixed-operators */ - const colorSensitivity = 1; // color sensitivity (values from 1 to 4) - const logNumber = 100 / Math.log10(100) ** colorSensitivity; percent = Math.round( - Math.log10(percent) ** colorSensitivity * logNumber + Math.log10(percent) ** this.colorSensitivity * this.logNumber ); } return { @@ -75,6 +78,9 @@ export default { }; }); }, + logNumber() { + return 100 / Math.log10(100) ** this.colorSensitivity; + } }, methods: { customClass(tokenItem) { From 90dffcb29ca86c2dc61908e6b57a7efda9826c0d Mon Sep 17 00:00:00 2001 From: leire Date: Wed, 16 Nov 2022 11:56:58 +0100 Subject: [PATCH 4/4] lint --- .../components/text-classifier/results/RecordExplain.vue | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/frontend/components/text-classifier/results/RecordExplain.vue b/frontend/components/text-classifier/results/RecordExplain.vue index c8ae6b12d1..56345c634d 100644 --- a/frontend/components/text-classifier/results/RecordExplain.vue +++ b/frontend/components/text-classifier/results/RecordExplain.vue @@ -43,8 +43,8 @@ export default { }, data() { return { - colorSensitivity: 1 // color sensitivity (values from 1 to 4) - } + colorSensitivity: 1, // color sensitivity (values from 1 to 4) + }; }, computed: { predicted() { @@ -80,7 +80,7 @@ export default { }, logNumber() { return 100 / Math.log10(100) ** this.colorSensitivity; - } + }, }, methods: { customClass(tokenItem) {