Skip to content

Update connection.js #117

Closed
wants to merge 1 commit into from

2 participants

@axelesha
axelesha commented Sep 8, 2013

I've spent entire day debugging the module, because no matter what I did - the TLS didn't connect, while the "raw" tls connection works perfect. So, i fugured out that probably due to recent TLS changes, if the "socket" present before connection inside of the options class - connection never happens.

Have fun.

@axelesha axelesha Update connection.js
I've spent entire day debugging the module, because no matter what I did - the TLS didn't connect, while the "raw" tls connection works perfect. So, i fugured out that probably due to recent TLS changes, if the "socket" present before connection inside of the options class - connection never happens.

Have fun.
0e61792
@argon
Owner
argon commented Sep 18, 2013

This isn't a valid fix, the code you have moved is now completely ignored, which may be a solution, but it shouldn't be there at all in that case. I believe this "fix" was put in place in a much older version while trying to fix a defect and may now be redundant. However I will close this pull request and fix separately.

@argon argon closed this Sep 18, 2013
@argon
Owner
argon commented Sep 18, 2013

Which version of node are you using?

@axelesha
@argon
Owner
argon commented Sep 22, 2013

I have been able to reproduce the problem. I am planning a new release which I will develop and release over the next few days, I will ensure this is fixed in time for it, thanks.

@argon
Owner
argon commented Sep 22, 2013

Have managed to fix this problem, as mentioned above it will be in the next release, however if you want to patch your install before then, the fix can be found in 12a8c14

@axelesha
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.