Extended callbacks #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t notification. successCallback is also added - useful in evented handling after a notification is sent
…for successCallback
|
in-complete. |
|
This would be a nice feature to have. Even though the information is available via the event system, from a control-flow sense, it would be nice to know if a request completed successfully or errored. |
|
There is now an event |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
great library!
i needed to have individual callbacks for each notification sent, (in a webserver environment that had it's own scope) . so have added support for an additional argument in sendNotification. i also added a successcalback that i have tested in this approach.
have added documentation & my edits as two commits.
cheers.
~B