Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

feedback service via proxy also requires rejectUnauthorized flag #66

Merged
merged 1 commit into from

2 participants

@4mo1

rejectUnauthorized flag in socket options needs to be applied to feedback service as well.

@argon argon merged commit 1ec14c8 into argon:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 4, 2012
  1. Add support for rejectUnauthorized in socket options when using a loc…

    Amol Neurgaonkar authored
    …al proxy
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 5 deletions.
  1. +2 −5 lib/feedback.js
View
7 lib/feedback.js
@@ -42,6 +42,7 @@ function Feedback(options) {
ca: null, /* Certificate Authority
address: 'feedback.push.apple.com', /* feedback address */
port: 2196, /* feedback port */
+ rejectUnauthorized: true, /* Set this to false incase using a local proxy, reject otherwise */
feedback: false, /* enable feedback service, set to callback */
errorCallback: false, /* error handler to catch connection exceptions */
interval: 3600, /* interval in seconds to connect to feedback service */
@@ -135,17 +136,13 @@ Feedback.prototype.connect = function () {
socketOptions.cert = this.certData;
socketOptions.passphrase = this.options.passphrase;
socketOptions.ca = this.options.ca;
+ socketOptions.rejectUnauthorized = this.options.rejectUnauthorized;
this.socket = tls.connect(
this.options['port'],
this.options['address'],
socketOptions,
function () {
- if (!this.socket.authorized) {
- this.deferredConnection.reject(this.socket.authorizationError);
- this.deferredConnection = null;
- }
-
debug("Connection established");
this.deferredConnection.resolve();
}.bind(this));
Something went wrong with that request. Please try again.