Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set subject on CA cert used for signing self-signed certs #582

Merged
merged 2 commits into from Mar 4, 2022

Conversation

jannfis
Copy link
Collaborator

@jannfis jannfis commented Mar 4, 2022

Signed-off-by: jannfis jann@mistrust.net

What type of PR is this?

/kind bug

What does this PR do / why we need it:

See redhat-developer/gitops-operator#277

Recent versions of Firefox refuse to process TLS certificates that are signed by an unnamed CA. The Operator uses a CA certificate that's created without a X509 Subject, and thus, Firefox chokes.

For an existing installation, the argocd-tls and argocd-ca secrets must be deleted and reconciled back by the Operator.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes redhat-developer/gitops-operator#277 redhat-developer/gitops-operator#261

How to test changes / Special notes to the reviewer:

  • Install a recent version of Firefox (I used 97.0.1 (64-bit), installed via Flatpak)
  • Create simple ArgoCD for the Operator to reconcile and to create a new Argo CD instance. If you use route, make sure that .server.route.tls.termination is set to passthrough (or left blank, because passthrough is the default)
  • Point Firefox to the Argo CD UI
  • Connection should be successful (the unknown certificate message is expected, but should be skippable)

Signed-off-by: jannfis <jann@mistrust.net>
@wtam2018
Copy link
Collaborator

wtam2018 commented Mar 4, 2022

LGTM
thanks @jannfis

@wtam2018 wtam2018 merged commit 11077ea into argoproj-labs:master Mar 4, 2022
7 checks passed
wtam2018 pushed a commit that referenced this pull request Mar 4, 2022
Signed-off-by: jannfis <jann@mistrust.net>
(cherry picked from commit 11077ea)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SEC_ERROR_BAD_DER on argo instannce
2 participants