Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example with Weights and Biases + distributed finetuning #932

Merged
merged 7 commits into from
Jan 19, 2024

Conversation

flaviuvadan
Copy link
Collaborator

I've been meaning to add these examples to the repo for a while. One is an example of how one can use WandB with Hera scripts, which is really not very different than the core Python example already documented here. The other example is from the talk I had the chance to give with @JPZ13 at KubeCon NA 2023. The example added in this PR is a flat representation of this repo. My hope with the two is illustrate that distributed training is much more accessible in Hera + Argo Workflows on K8s. Some useful references:

Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
@flaviuvadan flaviuvadan added semver:patch A change requiring a patch version bump type:enhancement A general enhancement labels Jan 18, 2024
flaviuvadan and others added 5 commits January 17, 2024 20:36
Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
I noticed that we don't have the CLI mentioned at all. I thought about
adding some docs about it to the README at least. I am sure we're going
to have a dedicated documentation page on RTFD at some point

---------

Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
Co-authored-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6adbe4) 80.3% compared to head (5233b78) 80.6%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #932     +/-   ##
=======================================
+ Coverage   80.3%   80.6%   +0.3%     
=======================================
  Files         49      49             
  Lines       3898    3898             
  Branches     792     792             
=======================================
+ Hits        3131    3145     +14     
+ Misses       573     565      -8     
+ Partials     194     188      -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elliotgunton elliotgunton added type:documentation A documentation update and removed type:enhancement A general enhancement labels Jan 19, 2024
@elliotgunton elliotgunton merged commit 448eb02 into main Jan 19, 2024
26 checks passed
@elliotgunton elliotgunton deleted the fv/wandb-example branch January 19, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants