Save dummy outputs when runner script raises an exception #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotgunton
force-pushed
the
write-outputs-on-error
branch
from
6e691bb
to
d72d71b
Compare
elliotgunton
added
semver:patch
elliotgunton
force-pushed
the
pydantic-io-docs
branch
from
1413916
to
720f650
Compare
elliotgunton
force-pushed
the
write-outputs-on-error
branch
from
d72d71b
to
7face1d
Compare
|
JFYI - This PR is on top of the Runner IO models to avoid redoing the work |
elliotgunton
force-pushed
the
pydantic-io-docs
branch
from
720f650
to
7941610
Compare
elliotgunton
force-pushed
the
write-outputs-on-error
branch
2 times, most recently
from
87e12ff
to
b768dde
Compare
elliotgunton
force-pushed
the
pydantic-io-docs
branch
2 times, most recently
from
d0f47a9
to
23e2929
Compare
elliotgunton
force-pushed
the
write-outputs-on-error
branch
from
b768dde
to
14168f8
Compare
elliotgunton
force-pushed
the
pydantic-io-docs
branch
from
23e2929
to
213cbf1
Compare
elliotgunton
force-pushed
the
write-outputs-on-error
branch
from
14168f8
to
02bbf3a
Compare
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
elliotgunton
force-pushed
the
write-outputs-on-error
branch
from
02bbf3a
to
fe779ac
Compare
elliotgunton
force-pushed
the
pydantic-io-docs
branch
from
213cbf1
to
db65509
Compare
samj1912
approved these changes
Feb 12, 2024
elliotgunton
added a commit
that referenced
this pull request
Feb 12, 2024
**Pull Request Checklist** - [x] Fixes #948 - [x] Tests added - [ ] Documentation/examples added - [x] [Good commit messages](https://cbea.ms/git-commit/) and/or PR title **Description of PR** When running a script via the Hera Runner, if it raises an error, the declared outputs of the (script) template are not created as files in the container, leading to confusing Argo logs such as: ``` msg="cannot save parameter /tmp/hera-outputs/parameters/my-parameter" argo=true error="open /tmp/hera-outputs/parameters/my-parameter: no such file or directory"` ``` This PR makes the runner catch the exception, write dummy values, then pass the exception up. Signed-off-by: Elliot Gunton <egunton@bloomberg.net> Co-authored-by: Sambhav Kothari <skothari44@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of PR
When running a script via the Hera Runner, if it raises an error, the declared outputs of the (script) template are not created as files in the container, leading to confusing Argo logs such as:
This PR makes the runner catch the exception, write dummy values, then pass the exception up.