From 32470908384a1ca3a7abf3331c73d62e13c30543 Mon Sep 17 00:00:00 2001
From: Alexander Matyushentsev <Alexander_Matyushentsev@intuit.com>
Date: Mon, 3 Jan 2022 11:31:12 -0800
Subject: [PATCH] feat: store "Group Nodes" button state in application details
 preferences (#8036)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
---
 .../application-details/application-details.tsx     | 13 ++++++-------
 .../app/shared/services/view-preferences-service.ts |  1 +
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/ui/src/app/applications/components/application-details/application-details.tsx b/ui/src/app/applications/components/application-details/application-details.tsx
index 5f402b7117954..0d2dc658785c4 100644
--- a/ui/src/app/applications/components/application-details/application-details.tsx
+++ b/ui/src/app/applications/components/application-details/application-details.tsx
@@ -33,7 +33,6 @@ interface ApplicationDetailsState {
     revision?: string;
     groupedResources?: ResourceStatus[];
     slidingPanelPage?: number;
-    showCompactNodes?: boolean;
 }
 
 interface FilterInput {
@@ -68,7 +67,7 @@ export class ApplicationDetails extends React.Component<RouteComponentProps<{nam
 
     constructor(props: RouteComponentProps<{name: string}>) {
         super(props);
-        this.state = {page: 0, groupedResources: [], slidingPanelPage: 0, showCompactNodes: false};
+        this.state = {page: 0, groupedResources: [], slidingPanelPage: 0};
     }
 
     private get showOperationState() {
@@ -97,8 +96,8 @@ export class ApplicationDetails extends React.Component<RouteComponentProps<{nam
         this.setState({slidingPanelPage: 0});
     }
 
-    private toggleCompactView() {
-        this.setState({showCompactNodes: !this.state.showCompactNodes});
+    private toggleCompactView(pref: AppDetailsPreferences) {
+        services.viewPreferences.updatePreferences({appDetails: {...pref, groupNodes: !pref.groupNodes}});
     }
 
     public render() {
@@ -256,9 +255,9 @@ export class ApplicationDetails extends React.Component<RouteComponentProps<{nam
                                                 <Filters pref={pref} tree={tree} onSetFilter={setFilter} onClearFilter={clearFilter}>
                                                     {pref.view === 'tree' && (
                                                         <button
-                                                            className={`argo-button argo-button--base${!this.state.showCompactNodes ? '-o' : ''}`}
+                                                            className={`argo-button argo-button--base${!pref.groupNodes ? '-o' : ''}`}
                                                             style={{border: 'none', width: '160px'}}
-                                                            onClick={() => this.toggleCompactView()}>
+                                                            onClick={() => this.toggleCompactView(pref)}>
                                                             <i className={classNames('fa fa-object-group')} style={{width: '15px', marginRight: '5px'}} />
                                                             Group Nodes
                                                         </button>
@@ -272,7 +271,7 @@ export class ApplicationDetails extends React.Component<RouteComponentProps<{nam
                                                                 this.getApplicationActionMenu(application, false)
                                                             )
                                                         }
-                                                        showCompactNodes={this.state.showCompactNodes}
+                                                        showCompactNodes={pref.groupNodes}
                                                         tree={tree}
                                                         app={application}
                                                         showOrphanedResources={pref.orphanedResources}
diff --git a/ui/src/app/shared/services/view-preferences-service.ts b/ui/src/app/shared/services/view-preferences-service.ts
index 605c63b1198f3..36491f2e4fdb2 100644
--- a/ui/src/app/shared/services/view-preferences-service.ts
+++ b/ui/src/app/shared/services/view-preferences-service.ts
@@ -15,6 +15,7 @@ export interface AppDetailsPreferences {
     darkMode: boolean;
     followLogs: boolean;
     hideFilters: boolean;
+    groupNodes?: boolean;
 }
 
 export interface PodViewPreferences {