From e55ecf910795950117ea45a2b65944bbad20974e Mon Sep 17 00:00:00 2001 From: Michael Crenshaw Date: Tue, 22 Mar 2022 15:54:37 -0400 Subject: [PATCH] chore: remove lint-docs CI task (#8722) (#8858) * chore: remove lint-docs CI task Signed-off-by: Alexander Matyushentsev * chore: remove not longer necessary url-allow-list Signed-off-by: Alexander Matyushentsev Co-authored-by: Alexander Matyushentsev --- .github/workflows/ci-build.yaml | 17 -------- Makefile | 4 -- docs/url-allow-list | 70 --------------------------------- 3 files changed, 91 deletions(-) delete mode 100644 docs/url-allow-list diff --git a/.github/workflows/ci-build.yaml b/.github/workflows/ci-build.yaml index e957031dce77..766c4f41f42a 100644 --- a/.github/workflows/ci-build.yaml +++ b/.github/workflows/ci-build.yaml @@ -427,20 +427,3 @@ jobs: name: e2e-server-k8s${{ matrix.k3s-version }}.log path: /tmp/e2e-server.log if: ${{ failure() }} - - lint-docs: - name: Lint docs - runs-on: ubuntu-latest - steps: - - name: Checkout code - uses: actions/checkout@v2 - - name: Setup Python - uses: actions/setup-python@v2 - with: - python-version: '3.x' - - name: Install dependencies - run: | - pip install -r docs/requirements.txt - - name: Lint docs - run: | - make lint-docs diff --git a/Makefile b/Makefile index 81057f733e41..8a18c80c8613 100644 --- a/Makefile +++ b/Makefile @@ -509,10 +509,6 @@ serve-docs-local: serve-docs: docker run ${MKDOCS_RUN_ARGS} --rm -it -p 8000:8000 -v ${CURRENT_DIR}:/docs ${MKDOCS_DOCKER_IMAGE} serve -a 0.0.0.0:8000 -.PHONY: lint-docs -lint-docs: - # https://github.com/dkhamsing/awesome_bot - find docs -name '*.md' -exec grep -l http {} + | xargs docker run --rm -v $(PWD):/mnt:ro dkhamsing/awesome_bot -t 3 --allow-dupe --allow-redirect --allow-timeout --allow-ssl --allow 502,500,429,400 --white-list `cat docs/url-allow-list | grep -v "#" | tr "\n" ','` --skip-save-results -- # Verify that kubectl can connect to your K8s cluster from Docker .PHONY: verify-kube-connect diff --git a/docs/url-allow-list b/docs/url-allow-list deleted file mode 100644 index e6f52a5c6713..000000000000 --- a/docs/url-allow-list +++ /dev/null @@ -1,70 +0,0 @@ -# a list of sites we ignore when checking for broken links in mkdocs -10.97.164.88 -192.168.0.20 -argocd.example.com -api.github.com/user -cd.apps.argoproj.io -docker-build -docker-build:443 -git.example.com -git.example.com:443 -github.com/argoproj/another-private-repo -github.com/argoproj/my-private-repository -github.com/argoproj/other-private-repo -github.com/argoproj/private-repo -github.com/otherproj/another-private-repo -ksonnet.io -raw.githubusercontent.com/argoproj/argo-cd -repo.example.com -repo.example.com:443 -server.example.com -kubernetes.default.svc -kubernetes.default.svc:443 -localhost:4000 -localhost:6443 -localhost:8080 -localhost:8085 -mycluster.com -storage.googleapis.com -ui.argocd.yourorganization.net -ui.argocd.yourorganization.net:443 -your-kubernetes-cluster-addr -yourorganization.oktapreview.com -yourorganization.oktapreview.com:443 -example-OIDC-provider.com -argocd-dex-server:5556 -ghe.example.com -proxy-server-url:8888 -keycloak.example.com -argocd.myproject.com -argocd.apps.domain.com -k8sou.apps.192-168-2-144.nip.io -your.argoingress.address -your.domain -external.path.to.argocd.io -my-argo-cd-url -my-login-url -login.microsoftonline.com/xxxxx -accounts.google.com/o/saml2/idp?idpid=Abcde0 -accounts.google.com/o/saml2?idpid=Abcde0 -sso-url -google-entity-id -github.com/argoproj/argo-cd/manifests/crds -example.com -form.example.com -grafana.example.com -10.5.39.39 -chat.googleapis.com/v1/spaces/ -mattermost.example.com -my-grafana.com -github.my-company.com -1.2.3.4 -2.4.6.8 -9.8.7.6 -ghe.example.com -12.34.567.89 -192.168.99.100:8443 -github.com/yourghuser/argo-cd -github.com/argoproj/argo-cd/releases/download/ -https://github.com/hayorov/helm-gcs.git; -grafana.apps.argoproj.io