You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With v1.3 first-class support of Helm, each repository has a type nominator to specify whether it's a Git or a Helm repo. The repo add command of the CLI has a corresponding switch, but this switch is not mandatory and not specifying the type has weird side-effects (i.e. assuming Helm repository for SSH URLs, which are not supported).
However, neither Git nor Helm is the dedicated default:
$ argocd repo add | grep -- --type
--type string type of the repository, "git" or "helm"
Expected behavior
Either the --type switch for repo add should be mandatory, or the default should be noted in the usage. If defaulting, the default should be git for backwards compatibility. If mandatory, maybe it should be a prepended argument instead of a switch, i.e. argocd add repo <type> <url> - this is open for discussion.
Screenshots
If applicable, add screenshots to help explain your problem.
Checklist:
argocd version
.Describe the bug
With v1.3 first-class support of Helm, each repository has a
type
nominator to specify whether it's a Git or a Helm repo. Therepo add
command of the CLI has a corresponding switch, but this switch is not mandatory and not specifying the type has weird side-effects (i.e. assuming Helm repository for SSH URLs, which are not supported).To Reproduce
Helm assumes HTTPS URL:
$ argocd repo add root@127.0.0.1:2222/app/git/repos/test --ssh-private-key-path test/fixture/testrepos/id_rsa --insecure-ignore-host-key FATA[0000] rpc error: code = Unknown desc = parse root@127.0.0.1:2222/app/git/repos/test: first path segment in URL cannot contain colon
Helm does not support explicit
ssh
protocol:$ argocd repo add ssh://root@127.0.0.1:2222/app/git/repos/test --ssh-private-key-path test/fixture/testrepos/id_rsa --insecure-ignore-host-key FATA[0000] rpc error: code = Unknown desc = Get ssh://root@127.0.0.1:2222/app/git/repos/test/index.yaml: unsupported protocol scheme "ssh"
However, neither Git nor Helm is the dedicated default:
Expected behavior
Either the
--type
switch forrepo add
should be mandatory, or the default should be noted in the usage. If defaulting, the default should begit
for backwards compatibility. If mandatory, maybe it should be a prepended argument instead of a switch, i.e.argocd add repo <type> <url>
- this is open for discussion.Screenshots
If applicable, add screenshots to help explain your problem.
Version
Logs
The text was updated successfully, but these errors were encountered: