-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impossible to add external HELM repos #3055
Comments
Hm, both error messages seem weird. Have you C&P'ed the repo URL from somewhere, and does it contain some non-printable characters in it maybe? Can you add Git repositories? Is anything in the logs of the |
p.s. I'm going to check:
|
Ah, thanks for the additional info. I think Helm repositories can't be connected when using a HTTP proxy server. That's an unfortunate current limitation, IIRC (see also #2826) |
We use a custom HTTP transport configuration for TLS parametrization, and it seems that it doesn't pick up the HTTP proxy environment variables in this function: Line 163 in a3f8ec3
The fix should be easy, as we're picking up the variables and parametrize the HTTP transport configuration for Git repositories already. |
@jannfis hold my 🍺 ...i'm attempting to build on my laptop the whole thing |
Basically, this should do it: $ git diff
diff --git a/util/helm/client.go b/util/helm/client.go
index 34447a8d..245e88ca 100644
--- a/util/helm/client.go
+++ b/util/helm/client.go
@@ -188,7 +188,10 @@ func (c *nativeHelmChart) GetIndex() (*Index, error) {
if err != nil {
return nil, err
}
- tr := &http.Transport{TLSClientConfig: tlsConf}
+ tr := &http.Transport{
+ Proxy: http.ProxyFromEnvironment,
+ TLSClientConfig: tlsConf,
+ }
client := http.Client{Transport: tr}
resp, err := client.Do(req)
if err != nil { If you have success with this patch, it would be awesome if you can check https://argoproj.github.io/argo-cd/CONTRIBUTING/ and submit a PR! :) |
nevermind... I'm still compiling the dependencies... 🤦♂️ ok, I will |
@jannfis pull request provided... the CI is failing, |
* attempting to fix HTTP|HTTPS|NO_PROXY env variable reading #3055 -> @jannfis tnx for the snippet ;) * adding a couple of sponsors references * fix! semanthic and form of the statement * doc: add ref. to companies that sponsored my work on ArgoCD #3055 * avoiding problems * Trigger notification Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Great! Can this fix be backported to 1.4? |
@alexmt ? is it a matter of a cherry-pick what @jkleinlercher wants or it involves more effort? |
@zep, @jkleinlercher . We plan to release 1.4.3 by end of week. Master got a lot of fixes since v1.4.2. Going to cherry-pick most of them into v1.4.3 |
Released in 1.5.0-rc1 |
via web or via cli
same issue... these are the versions involved
The text was updated successfully, but these errors were encountered: