Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declaratively add helm repositories #747

Closed
amarrella opened this issue Nov 6, 2018 · 4 comments
Closed

Declaratively add helm repositories #747

amarrella opened this issue Nov 6, 2018 · 4 comments
Assignees
Milestone

Comments

@amarrella
Copy link
Contributor

@amarrella amarrella commented Nov 6, 2018

Hello, I'm facing a problem where one of my requirements.yaml is hosted on a non-default repo.
It would be nice to have a way to add the repo to helm in a declarative way. Currently my argocd deploy fails due to the fact that it needs to execute "helm repo add" :(
Thanks in advance, and thank you for this great project :)

@jessesuen

This comment has been minimized.

Copy link
Contributor

@jessesuen jessesuen commented Nov 7, 2018

I think this request makes sense. Question is, is there a way to infer what values to use for [NAME] and [URL] after helm repo add?

If not, one way is that we introduce a helm specific section in the argocd-cm ConfigMap where we hold global helm repo's, urls, and username/passwords as secret references.

This is also relevant to the work we are doing for:
#536

@mduarte

This comment has been minimized.

Copy link
Contributor

@mduarte mduarte commented Nov 13, 2018

I don't think there's a way to infer that, but I am not helm specialist :)

The option to introduce a a helm specific section in the argocd-cm ConfigMap seems to me the most declarative and flexible way to implement this.

@jessesuen

This comment has been minimized.

Copy link
Contributor

@jessesuen jessesuen commented Nov 14, 2018

The istio helm chart is example of where they use subcharts (in the same repo) and may require repo registration. When trying to create istio from the path: install/kubernetes/helm/istio, the application error we get is:

rpc error: code = Unknown desc = Error: no repository definition for @istio.io. Please add them via ‘helm repo add’

@jessesuen

This comment has been minimized.

Copy link
Contributor

@jessesuen jessesuen commented Dec 1, 2018

@alexmt - when using disposable HELM_HOME directories, please initiate the helm dir using the command: helm init --client-only --skip-refresh. The --skip-refresh flag prevents an attempt to reach out over the network to download the repo index, which is necessary for any users who are using fire-walled networks.

@jessesuen jessesuen added this to the v0.11 milestone Dec 3, 2018
alexmt added a commit to alexmt/argo-cd that referenced this issue Dec 3, 2018
alexmt added a commit to alexmt/argo-cd that referenced this issue Dec 3, 2018
@alexmt alexmt self-assigned this Dec 3, 2018
alexmt added a commit to alexmt/argo-cd that referenced this issue Dec 3, 2018
alexmt added a commit to alexmt/argo-cd that referenced this issue Dec 3, 2018
alexmt added a commit to alexmt/argo-cd that referenced this issue Dec 3, 2018
@alexmt alexmt closed this in #864 Dec 3, 2018
alexmt added a commit that referenced this issue Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.