Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upDeprecate componentParameterOverrides in favor of source specific config #1207
+2,492
−1,696
Conversation
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Mar 1, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #1207 +/- ##
==========================================
+ Coverage 36.27% 36.45% +0.18%
==========================================
Files 59 59
Lines 8749 8777 +28
==========================================
+ Hits 3174 3200 +26
- Misses 5114 5117 +3
+ Partials 461 460 -1
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
Example of the new history. Notice it is able to switch between repo paths and app source types. - deployedAt: "2019-03-01T07:28:32Z"
id: 12
revision: a95c7943effa602740aa54fe4755ad3f4870bee3
source:
ksonnet:
environment: default
path: ksonnet-guestbook
repoURL: https://github.com/argoproj/argocd-example-apps
targetRevision: HEAD
- deployedAt: "2019-03-01T07:28:44Z"
id: 13
revision: a95c7943effa602740aa54fe4755ad3f4870bee3
source:
ksonnet:
environment: default
path: ksonnet-guestbook
repoURL: https://github.com/argoproj/argocd-example-apps
targetRevision: HEAD
- deployedAt: "2019-03-01T07:29:06Z"
id: 14
revision: a95c7943effa602740aa54fe4755ad3f4870bee3
source:
path: guestbook
repoURL: https://github.com/argoproj/argocd-example-apps
targetRevision: HEAD |
LGTM |
…alizatoin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jessesuen commentedMar 1, 2019
•
edited
Resolves #1141
Resolves #1196
Removes the legacy
spec.source.environment
andspec.source.valuesFiles
which were deprecated in v0.11Fixes small issue where
argocd app create APPNAME --file
didn't fail when there were name conflictsResolves: #1201
Resolves: #1208