Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate componentParameterOverrides in favor of source specific config #1207

Merged
merged 2 commits into from Mar 4, 2019

Conversation

@jessesuen
Copy link
Contributor

jessesuen commented Mar 1, 2019

  1. begins the deprecation process of componentParameterOverrides. Application reconciliation will invoke migration logic to move componentParameterOverrides to their new locations in ksonnet.parameters, helm.parameters, and kustomize.imageTags. componentParameterOverrides will be removed in a future release (likely the next release).

Resolves #1141

  1. With the deprecation of componentParameterOverrides, we now store the entire appSource as part of sync history. This allows us to rollback even when user changes things like the repo, path, kustomize namePrefix, etc...

Resolves #1196

  1. Removes the legacy spec.source.environment and spec.source.valuesFiles which were deprecated in v0.11

  2. Fixes small issue where argocd app create APPNAME --file didn't fail when there were name conflicts

Resolves: #1201

  1. Fixes issue where auto-sync and app deletion would fight each other

Resolves: #1208

@jessesuen jessesuen requested review from alexmt and alexec Mar 1, 2019
@jessesuen jessesuen force-pushed the jessesuen:deprecate-cpo branch from 5b82164 to b607102 Mar 1, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 1, 2019

Codecov Report

Merging #1207 into master will increase coverage by 0.18%.
The diff coverage is 68.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1207      +/-   ##
==========================================
+ Coverage   36.27%   36.45%   +0.18%     
==========================================
  Files          59       59              
  Lines        8749     8777      +28     
==========================================
+ Hits         3174     3200      +26     
- Misses       5114     5117       +3     
+ Partials      461      460       -1
Impacted Files Coverage Δ
util/cache/cache.go 0% <0%> (ø) ⬆️
controller/state.go 74.73% <100%> (-0.27%) ⬇️
util/argo/diff_normalizer.go 77.19% <100%> (ø) ⬆️
reposerver/repository/repository.go 34.15% <19.04%> (-1.76%) ⬇️
server/application/application.go 27.61% <66.66%> (-0.13%) ⬇️
util/kustomize/kustomize.go 77.66% <69.23%> (+0.21%) ⬆️
controller/sync.go 70.79% <70.58%> (+0.26%) ⬆️
util/argo/argo.go 29.56% <73.13%> (+7.49%) ⬆️
util/helm/helm.go 62.39% <75%> (+0.32%) ⬆️
controller/appcontroller.go 30.43% <93.75%> (+1.18%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a848090...76812d3. Read the comment docs.

@jessesuen jessesuen force-pushed the jessesuen:deprecate-cpo branch from b607102 to 90b3aef Mar 1, 2019
@jessesuen jessesuen force-pushed the jessesuen:deprecate-cpo branch from 90b3aef to 76812d3 Mar 1, 2019
@jessesuen

This comment has been minimized.

Copy link
Contributor Author

jessesuen commented Mar 1, 2019

Example of the new history. Notice it is able to switch between repo paths and app source types.

  - deployedAt: "2019-03-01T07:28:32Z"
    id: 12
    revision: a95c7943effa602740aa54fe4755ad3f4870bee3
    source:
      ksonnet:
        environment: default
      path: ksonnet-guestbook
      repoURL: https://github.com/argoproj/argocd-example-apps
      targetRevision: HEAD
  - deployedAt: "2019-03-01T07:28:44Z"
    id: 13
    revision: a95c7943effa602740aa54fe4755ad3f4870bee3
    source:
      ksonnet:
        environment: default
      path: ksonnet-guestbook
      repoURL: https://github.com/argoproj/argocd-example-apps
      targetRevision: HEAD
  - deployedAt: "2019-03-01T07:29:06Z"
    id: 14
    revision: a95c7943effa602740aa54fe4755ad3f4870bee3
    source:
      path: guestbook
      repoURL: https://github.com/argoproj/argocd-example-apps
      targetRevision: HEAD
server/application/application.go Show resolved Hide resolved
controller/appcontroller.go Outdated Show resolved Hide resolved
@jessesuen jessesuen force-pushed the jessesuen:deprecate-cpo branch from 176e778 to 9142dd1 Mar 4, 2019
@jessesuen jessesuen requested a review from alexmt Mar 4, 2019
@alexmt
alexmt approved these changes Mar 4, 2019
Copy link
Contributor

alexmt left a comment

LGTM

…alizatoin
@jessesuen jessesuen force-pushed the jessesuen:deprecate-cpo branch from 9142dd1 to c76a675 Mar 4, 2019
@jessesuen jessesuen merged commit cc7b283 into argoproj:master Mar 4, 2019
2 checks passed
2 checks passed
default Argo CI
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.